Setup private feeds for tests #43041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ViktorHofer
reviewed
Aug 27, 2024
ViktorHofer
approved these changes
Aug 27, 2024
| - task: Bash@3 | ||
| displayName: Setup Private Feeds Credentials | ||
| inputs: | ||
| filePath: $(sourcesPath)/src/sdk/eng/common/SetupNugetSources.sh |
There was a problem hiding this comment.
(Orthogonal comment) Isn't this going to be needed for the unified build when we do official release builds (non-source-build)? It would be needed before the build.
There was a problem hiding this comment.
Logged https://github.com/dotnet/source-build/issues/4584 for this.
MichaelSimons
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous refactoring of the VMR pipeline mistakenly removed the pipeline steps which setup the private feed credentials for the NuGet.config used by tests. This causes the error described in dotnet/source-build#4583 (comment).
This is resolved by adding back the pipeline steps that were removed. One difference here is that now we also run the scenario tests in addition to the source build smoke tests. The scenario tests have the same issue as they just copy in the NuGet.config file from the sdk repo. To resolve both of these, the sdk repo's NuGet.config file is directly updated by the
SetupNuGetSources.sh. That updated file then is used as the source for both test suites.Fixes dotnet/source-build#4583
Note that this won't fix RC1 builds. There's no time to get this change in for RC1. But that branch has been privately verified with this fix.