-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update the sdk target to net10.0 #43015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
8480f31
Update the sdk target to net10.0
v-wuzhai 10d8ad6
Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/U…
v-wuzhai 6003d81
Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/U…
v-wuzhai ba19dd8
Unlock the build
v-wuzhai d69e52c
Add an empty Directory.Build.targets
mmitche eb0cd8a
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
mmitche c4d1281
Switch the resolvers and test project to net10.0
marcpopMSFT 7d18b09
Move dotnet-format to use SdkTargetFramework
mmitche 62d7486
Fix the template tests but we need to check on this as the current ou…
marcpopMSFT 58ce796
Update source build global.json
marcpopMSFT 27881c4
Update the current target to 10.0 as some tests automatically update …
marcpopMSFT 7c671f9
Fix the formatting of some of the templating tests
marcpopMSFT 83b8fdc
Web templates have moved to target net10.0 already
marcpopMSFT b18d98f
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
marcpopMSFT b715ece
Update according to the comments
v-wuzhai d40538b
Fix version
v-wuzhai a951a65
The current .NET SDK does not support targeting .NET 11.0
v-wuzhai 742a88d
Attempting to unlock a bunch of test failures
v-wuzhai bd1d57a
Temporarily disable a test as we can't reference across TFMs. This ca…
marcpopMSFT 9ae75b6
Update the regex to handle 5+
marcpopMSFT b676bbb
After talking to baronfel, disabling some container tests for now unt…
marcpopMSFT 505ea26
Disable a couple more container tests
marcpopMSFT 3133bcf
Add ignoredPatterns in NotHaveStdOutContaining
am11 6a07932
Ignore __compact_unwind warnings
am11 e6c3248
Ignore clang-16 warning as well
am11 252429d
Add temp logging
jkotas 7f1ec30
Add .NET 9.0 TFM to PublishTestUtils
jkotas 284e14c
Revert "Add temp logging"
jkotas 9c9f903
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
jkotas 1bd7bd2
Avoid test directory name collisions
jkotas 95f5fa9
Merge remote-tracking branch 'am11/ignore-ld-warning' into dev/Jason/…
jkotas 50b52b1
Add comments
jkotas 2833c53
Set NetCurrent accordingly and downgrade VMR SDK
ViktorHofer d99e5d0
Set NetCoreAppToolCurrent to SDK value
ViktorHofer 24c81d3
Forward NetCoreAppToolCurrentVersion
ViktorHofer 5298648
Update 0001-Forward-NetCoreAppToolCurrent-switch.patch
ViktorHofer 89790ca
Fix patch
ViktorHofer 556992a
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
ViktorHofer 309f381
Add patch for hardcoded LinkTask TFM
ViktorHofer 73fa346
update patches because of sync failure
ViktorHofer 8f1f484
CLRF -> LF in patch
ViktorHofer a41669d
Update hardcoded tareting and runtime pack versions
ViktorHofer 7909f2d
TestCLI package is net9.0
ViktorHofer 98bd6dd
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
ViktorHofer 8091644
Apply suggestions from code review
jkotas f61431e
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
ViktorHofer 7cdb0cb
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
ViktorHofer 7933a2c
Update and rename 0001-Forward-NetCoreAppToolCurrentVersion-property-…
ViktorHofer ff69d51
Update patches
ViktorHofer bdd67a2
Update patch again...
ViktorHofer 6f4353a
Add another runtime patch
ViktorHofer 4c08007
damn... update patches again
ViktorHofer 4693dfd
and again...
ViktorHofer 5c810ad
Update SDKs
ViktorHofer e64a7b3
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
ViktorHofer 012bedb
Remove now unnecessary patch
ViktorHofer 6441219
Update to new prebuilts tarball version
ellahathaway 7bc9f92
Apply suggestions from code review
jkoritzinsky 18659d8
Update prebuilts tarball
ellahathaway 27a0734
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
ViktorHofer d6ad34d
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
ViktorHofer 4aa59bd
Set rollforward policy for VMR test projects
ViktorHofer 5456196
Disable Publish60Hosted_Works until 8.0.5 is available on .NET Framework
ViktorHofer bfa607a
Update prebuilts tarball
mthalman 8f28cbc
switch to the windows only msbuild fact
marcpopMSFT 6d2c4eb
Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0
nagilson 7a3c6e7
Add Reason property to and update baselines
v-wuzhai 482ad03
Add wpf patch
ViktorHofer c0cdf43
Add Arcade patch
ViktorHofer 575036c
Damn, I hate patches
ViktorHofer 3820c21
Add windowsdesktop patch
ViktorHofer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
src/SourceBuild/patches/arcade/0001-Update-workaround-for-STJ-8.0.0.4-version.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
From c0c75f6fa385d6959cc2c7c475c01208f9f30830 Mon Sep 17 00:00:00 2001 | ||
From: Viktor Hofer <viktor.hofer@microsoft.com> | ||
Date: Tue, 5 Nov 2024 13:37:06 +0100 | ||
Subject: [PATCH] Update workaround for STJ 8.0.0.4 version | ||
|
||
Backport: https://github.com/dotnet/arcade/pull/15218 | ||
|
||
--- | ||
src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets | 2 +- | ||
1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
||
diff --git a/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets b/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets | ||
index 492130d40..bae31b868 100644 | ||
--- a/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets | ||
+++ b/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets | ||
@@ -197,7 +197,7 @@ | ||
<![CDATA[ | ||
try | ||
{ | ||
- System.Reflection.Assembly.LoadFrom(@"$(MicrosoftNETBuildTasksDirectoryRoot)\..\..\..\DotnetTools\dotnet-format\BuildHost-net472\System.Text.Json.dll"); | ||
+ System.Reflection.Assembly.LoadFrom(@"$(MicrosoftNETBuildTasksDirectoryRoot)\..\..\..\Sdks\Microsoft.NET.Sdk.StaticWebAssets\tasks\net472\System.Text.Json.dll"); | ||
} | ||
catch | ||
{ |
89 changes: 89 additions & 0 deletions
89
src/SourceBuild/patches/windowsdesktop/0001-Update-SDK-and-remove-net10-workaround.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
From d6d8add5aad503877ee4344bce77dfa0b054752a Mon Sep 17 00:00:00 2001 | ||
From: Viktor Hofer <viktor.hofer@microsoft.com> | ||
Date: Tue, 5 Nov 2024 14:53:29 +0000 | ||
Subject: [PATCH] Update SDK and remove net10 workaround | ||
|
||
Backport: https://github.com/dotnet/windowsdesktop/pull/4763 | ||
|
||
--- | ||
Directory.Build.props | 2 +- | ||
Directory.Build.targets | 18 ------------------ | ||
global.json | 2 +- | ||
.../src/sfx/Directory.Build.targets | 12 ++++++++++++ | ||
4 files changed, 14 insertions(+), 20 deletions(-) | ||
|
||
diff --git a/Directory.Build.props b/Directory.Build.props | ||
index 09e49d41..daf75b2f 100644 | ||
--- a/Directory.Build.props | ||
+++ b/Directory.Build.props | ||
@@ -26,7 +26,7 @@ | ||
<!-- Only upgrade NuGetAudit warnings to errors for official builds. --> | ||
<WarningsNotAsErrors Condition="'$(OfficialBuild)' != 'true'">$(WarningsNotAsErrors);NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors> | ||
|
||
- <!-- Temporary, reove when arcade NetCurrent to net10. This requires a net10 targeting SDK --> | ||
+ <!-- Temporary, remove when arcade NetCurrent to net10. This requires a net10 targeting SDK. --> | ||
<NetCurrent>net10.0</NetCurrent> | ||
</PropertyGroup> | ||
|
||
diff --git a/Directory.Build.targets b/Directory.Build.targets | ||
index d816857c..7b2a3390 100644 | ||
--- a/Directory.Build.targets | ||
+++ b/Directory.Build.targets | ||
@@ -10,22 +10,4 @@ | ||
<NETCoreAppMaximumVersion>$(MajorVersion).$(MinorVersion)</NETCoreAppMaximumVersion> | ||
</PropertyGroup> | ||
|
||
- <ItemGroup> | ||
- <!-- After the net10 SDK is available, this should change back to an Update without the TargetFramework property. --> | ||
- <KnownFrameworkReference | ||
- Include="@(KnownFrameworkReference->WithMetadataValue('TargetFramework', 'net9.0'))" | ||
- DefaultRuntimeFrameworkVersion="$(MicrosoftNETCoreAppRefVersion)" | ||
- LatestRuntimeFrameworkVersion="$(MicrosoftNETCoreAppRefVersion)" | ||
- TargetingPackVersion="$(MicrosoftNETCoreAppRefVersion)" | ||
- TargetFramework="net10.0" /> | ||
- <KnownFrameworkReference Remove="Microsoft.AspNetCore.App" /> | ||
- <KnownFrameworkReference Remove="Microsoft.WindowsDesktop.App" /> | ||
- <KnownFrameworkReference Remove="Microsoft.WindowsDesktop.App.WindowsForms" /> | ||
- <KnownFrameworkReference Remove="Microsoft.WindowsDesktop.App.WPF" /> | ||
- | ||
- <KnownCrossgen2Pack Include="@(KnownCrossgen2Pack->WithMetadataValue('TargetFramework', 'net9.0'))" | ||
- Crossgen2PackVersion="$(MicrosoftNETCoreAppRefVersion)" | ||
- TargetFramework="net10.0" /> | ||
- </ItemGroup> | ||
- | ||
</Project> | ||
diff --git a/global.json b/global.json | ||
index 0e7f27a5..412fb4a9 100644 | ||
--- a/global.json | ||
+++ b/global.json | ||
@@ -1,6 +1,6 @@ | ||
{ | ||
"tools": { | ||
- "dotnet": "9.0.100-rc.2.24474.11", | ||
+ "dotnet": "10.0.100-alpha.1.24551.9", | ||
"runtimes": { | ||
"dotnet": [ | ||
"$(VSRedistCommonNetCoreSharedFrameworkx64100PackageVersion)" | ||
diff --git a/src/windowsdesktop/src/sfx/Directory.Build.targets b/src/windowsdesktop/src/sfx/Directory.Build.targets | ||
index 82de7dd9..ca14567b 100644 | ||
--- a/src/windowsdesktop/src/sfx/Directory.Build.targets | ||
+++ b/src/windowsdesktop/src/sfx/Directory.Build.targets | ||
@@ -2,6 +2,18 @@ | ||
|
||
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., Directory.Build.targets))\Directory.Build.targets" /> | ||
|
||
+ <ItemGroup> | ||
+ <KnownFrameworkReference | ||
+ Update="Microsoft.NETCore.App" | ||
+ DefaultRuntimeFrameworkVersion="$(MicrosoftNETCoreAppRefVersion)" | ||
+ LatestRuntimeFrameworkVersion="$(MicrosoftNETCoreAppRefVersion)" | ||
+ TargetingPackVersion="$(MicrosoftNETCoreAppRefVersion)" /> | ||
+ <KnownFrameworkReference Remove="Microsoft.AspNetCore.App" /> | ||
+ <KnownFrameworkReference Remove="Microsoft.WindowsDesktop.App" /> | ||
+ <KnownFrameworkReference Remove="Microsoft.WindowsDesktop.App.WindowsForms" /> | ||
+ <KnownFrameworkReference Remove="Microsoft.WindowsDesktop.App.WPF" /> | ||
+ </ItemGroup> | ||
+ | ||
<ItemGroup> | ||
<PackageReference Include="Microsoft.DotNet.Build.Tasks.Archives" /> | ||
</ItemGroup> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.