Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 13, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: cedddd63-79f5-4e7e-6d46-08dc434c4948
  • Build: 20240813.14
  • Date Produced: August 14, 2024 5:02:47 AM UTC
  • Commit: 605ff6f6485101d4bd1eabb9ab97af345eee67a1
  • Branch: refs/heads/main

…0812.13

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-rc.1.24410.5 -> To Version 9.0.0-rc.1.24412.13
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Aug 13, 2024
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/runtime:

@dotnet/dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…0813.14

Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64
 From Version 9.0.0-rc.1.24412.13 -> To Version 9.0.0-rc.1.24413.14
@eerhardt
Copy link
Member

cc @jozkee - the build errors look to be related to dotnet/runtime#106360.

/vmr/src/sdk/src/Installer/redist-installer/targets/BundledTemplates.targets(4,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "CalculateTemplateVersions" task failed unexpectedly.
System.TypeLoadException: Could not load type 'System.Runtime.InteropServices.MemoryMarshal' from assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at <PrivateImplementationDetails>.InlineArrayAsReadOnlySpan[TBuffer,TElement](TBuffer& buffer, Int32 length)
   at Microsoft.DotNet.Cli.Build.CalculateTemplateVersions.<>c__DisplayClass29_0.<Execute>b__4(KeyValuePair`2 g) in /_/src/sdk/src/Installer/core-sdk-tasks/CalculateTemplateVersions.cs:line 70
   at System.Linq.Enumerable.IEnumerableSelectIterator`2.ToArray()
   at Microsoft.DotNet.Cli.Build.CalculateTemplateVersions.Execute() in /_/src/sdk/src/Installer/core-sdk-tasks/CalculateTemplateVersions.cs:line 63
   at Microsoft.Build.BackEnd.TaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

@artl93
Copy link
Member

artl93 commented Aug 14, 2024

@AaronRobinsonMSFT or @agocke - do you know if something changed in InlineArrayAsReadOnlySpan that might impact the following?

/vmr/src/sdk/src/Installer/redist-installer/targets/BundledTemplates.targets(4,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "CalculateTemplateVersions" task failed unexpectedly.
System.TypeLoadException: Could not load type 'System.Runtime.InteropServices.MemoryMarshal' from assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
at .InlineArrayAsReadOnlySpan[TBuffer,TElement](TBuffer& buffer, Int32 length)
at Microsoft.DotNet.Cli.Build.CalculateTemplateVersions.<>c__DisplayClass29_0.b__4(KeyValuePair2 g) in /_/src/sdk/src/Installer/core-sdk-tasks/CalculateTemplateVersions.cs:line 70 at System.Linq.Enumerable.IEnumerableSelectIterator2.ToArray()
at Microsoft.DotNet.Cli.Build.CalculateTemplateVersions.Execute() in /_/src/sdk/src/Installer/core-sdk-tasks/CalculateTemplateVersions.cs:line 63
at Microsoft.Build.BackEnd.TaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

@jozkee
Copy link
Member

jozkee commented Aug 14, 2024

cc @ericstj @dotnet/area-infrastructure-libraries any suggestions on how to fix this?

@artl93
Copy link
Member

artl93 commented Aug 14, 2024

@dotnet/domestic-cat - could this be coming from an SDK change? (See previous comment.)

@Forgind
Copy link
Contributor

Forgind commented Aug 14, 2024

@dotnet/domestic-cat - could this be coming from an SDK change? (See previous comment.)

This PR doesn't really have any SDK changes, and other PRs that came out afterwards aren't failing with this, so I'm pretty sure it's from a runtime change, most likely dotnet/runtime#106360 as eerhardt suggested. Since it's trying to load it from System.Runtime, that suggests to me that it probably sees the ref assembly, then goes to the real assembly and can't find it. I'm not sure what to do about that, though. Wait for it to resolve itself with a future update? Update the global.json?

@agocke
Copy link
Member

agocke commented Aug 14, 2024

From the stack trace, it looks like this is a build task that is somehow being compiled against the live runtime, but run against stock MSBuild.

Presumably the problem is "build task compiled against the live runtime." I don't know how to fix that -- this would require a deeper investigation and potentially some infrastructure re-architecture.

@ericstj
Copy link
Member

ericstj commented Aug 14, 2024

Yeah, this task is compiled against live refs, but then run on the toolset runtime. Let me see if I can determine how it gets it's references.

@ericstj
Copy link
Member

ericstj commented Aug 14, 2024

It's this project: https://github.com/dotnet/sdk/blob/f6b5eb1c6031d05627f62c2a052dea206fd56ea6/src/Installer/core-sdk-tasks/core-sdk-tasks.csproj

Seems like it needs a similar exclusion here:

<!-- Update KnownFrameworkReferences to target the right version of the runtime -->
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'
and $(MicrosoftNETCoreAppRefPackageVersion.StartsWith('$(_TargetFrameworkVersionWithoutV)'))
and '$(MSBuildProjectName)' != 'toolset-tasks'">

This needs to run on the toolset runtime, so it should not compile
against the live targeting pack.
@ericstj ericstj requested review from a team as code owners August 14, 2024 19:13
@ericstj
Copy link
Member

ericstj commented Aug 14, 2024

I added a patch for the WPF failure, there was still a build failure on the primary CI job for OSX:

/Users/runner/work/1/s/.dotnet/sdk/9.0.100-preview.5.24307.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Publish.targets(355,5): error MSB3030: Could not copy the file "/Users/runner/work/1/s/test/TestAssets/TestPackages/dotnet-hello/v1/dotnet-hello/obj/a8d93160-c519-48a5-8813-bc2830cbdd92.tmp" because it was not found. [/Users/runner/work/1/s/test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests.csproj::TargetFramework=net9.0]
##[error].dotnet/sdk/9.0.100-preview.5.24307.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Publish.targets(355,5): error MSB3030: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy the file "/Users/runner/work/1/s/test/TestAssets/TestPackages/dotnet-hello/v1/dotnet-hello/obj/a8d93160-c519-48a5-8813-bc2830cbdd92.tmp" because it was not found.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=775857&view=logs&j=bd984918-332a-5954-fad9-103f3254a889&t=b308b3ab-01af-58d5-d851-72051b2c582c&l=691

Let's see if it repros.

@Forgind
Copy link
Contributor

Forgind commented Aug 14, 2024

I added a patch for the WPF failure, there was still a build failure on the primary CI job for OSX:

/Users/runner/work/1/s/.dotnet/sdk/9.0.100-preview.5.24307.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Publish.targets(355,5): error MSB3030: Could not copy the file "/Users/runner/work/1/s/test/TestAssets/TestPackages/dotnet-hello/v1/dotnet-hello/obj/a8d93160-c519-48a5-8813-bc2830cbdd92.tmp" because it was not found. [/Users/runner/work/1/s/test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests.csproj::TargetFramework=net9.0]
##[error].dotnet/sdk/9.0.100-preview.5.24307.3/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Publish.targets(355,5): error MSB3030: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy the file "/Users/runner/work/1/s/test/TestAssets/TestPackages/dotnet-hello/v1/dotnet-hello/obj/a8d93160-c519-48a5-8813-bc2830cbdd92.tmp" because it was not found.

https://dev.azure.com/dnceng-public/public/_build/results?buildId=775857&view=logs&j=bd984918-332a-5954-fad9-103f3254a889&t=b308b3ab-01af-58d5-d851-72051b2c582c&l=691

Let's see if it repros.

I've been seeing that in some other branches (and sometimes for linux); when I rerun, it goes away. Probably worth more investigation than that at some point or at least filing a known issue.

@ericstj
Copy link
Member

ericstj commented Aug 14, 2024

I have a theory here about what's happening. Test crosstalk. One test creates that file in a shared directory, then deletes it, meanwhile some other test is running a publish and sees the file, and it's deleted before it can run copy. Do you have a log file of the failure? AzDo helpfully deleted this one since the build was cancelled 😖

@Forgind
Copy link
Contributor

Forgind commented Aug 14, 2024

I have a theory here about what's happening. Test crosstalk. One test creates that file in a shared directory, then deletes it, meanwhile some other test is running a publish and sees the file, and it's deleted before it can run copy. Do you have a log file of the failure? AzDo helpfully deleted this one since the build was cancelled 😖

Unfortunately no ☹️ AzDO also overwrites logs when you rerun a leg. This was an example of what I'd seen:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=775622&view=logs&j=d68b235e-d7af-5bf6-c242-f1e29d5991d8&s=6884a131-87da-5381-61f3-d7acc3b91d76&t=66a8a60b-3425-5f4b-0913-eda6aa5aadd4&l=770
but you can see its log is gone.

@ericstj
Copy link
Member

ericstj commented Aug 14, 2024

I have a theory here about what's happening. Test crosstalk. One test creates that file in a shared directory, then deletes it, meanwhile some other test is running a publish and sees the file, and it's deleted before it can run copy. Do you have a log file of the failure? AzDo helpfully deleted this one since the build was cancelled 😖

Unfortunately no ☹️ AzDO also overwrites logs when you rerun a leg. This was an example of what I'd seen: https://dev.azure.com/dnceng-public/public/_build/results?buildId=775622&view=logs&j=d68b235e-d7af-5bf6-c242-f1e29d5991d8&s=6884a131-87da-5381-61f3-d7acc3b91d76&t=66a8a60b-3425-5f4b-0913-eda6aa5aadd4&l=770 but you can see its log is gone.

I saw it mentioned in all of these, but none have logs: https://github.com/dotnet/sdk/pulls?q=is%3Apr+%22because+it+was+not+found%22+is%3Aclosed+tmp

Next time you see it, try to ascertain which things are running concurrently (bin log or test logs might give enough hint) and see if they are sharing the same directory. Fix is likely just to make those not run concurrently, or use unique directories.

@ericstj ericstj requested a review from a team as a code owner August 14, 2024 22:31
"ILLink : Trim analysis warning IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object, Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.",
"ILLink : Trim analysis warning IL2026: System.ComponentModel.AmbientValueAttribute.AmbientValueAttribute(Type, String): Using member 'System.ComponentModel.AmbientValueAttribute.<.ctor>g__TypeDescriptorGetConverter|1_0(Type)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. AmbientValueAttribute usage of TypeConverter is not compatible with trimming.",
"ILLink : Trim analysis warning IL2026: System.ComponentModel.DefaultValueAttribute.DefaultValueAttribute(Type, String): Using member 'System.ComponentModel.DefaultValueAttribute.<.ctor>g__TryConvertFromInvariantString|5_0(Type, String, Object&)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. DefaultValueAttribute usage of TypeConverter is not compatible with trimming."
"ILLink : Trim analysis warning IL2026: System.ComponentModel.AmbientValueAttribute.AmbientValueAttribute(Type, String): Using member",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by this change.

  1. What changed that caused this to fail?
  2. Why does the warning just run off? : Using member

cc @sbomer @agocke

Copy link
Member

@ericstj ericstj Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These warnings can be partial matches, have a look at all the others in the same test. The content of the warning changed because we modified the class layout of this type which changed the <.ctor>g__TypeDescriptorGetConverter|1_0(Type) to <.ctor>g__TypeDescriptorGetConverter|2_0(Type).

By omitting these unstable internal implementation details the test will be more maintainable.

We'll avoid things like 3838072 and 4cafca4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @ericstj.

@ericstj ericstj enabled auto-merge (squash) August 15, 2024 02:15
@ericstj ericstj closed this Aug 15, 2024
auto-merge was automatically disabled August 15, 2024 02:16

Pull request was closed

@ericstj ericstj reopened this Aug 15, 2024
@ericstj ericstj enabled auto-merge (squash) August 15, 2024 02:16
@ericstj
Copy link
Member

ericstj commented Aug 15, 2024

@lewing
Copy link
Member

lewing commented Aug 15, 2024

The builds passed but for some reason badges weren't updating: https://dev.azure.com/dnceng-public/public/_build/results?buildId=776300&view=results https://dev.azure.com/dnceng-public/public/_build/results?buildId=776301&view=results https://dev.azure.com/dnceng-public/public/_build/results?buildId=776302&view=results

I was hoping close / reopen would fix it, but instead it's requeued the builds 😭

they probably got hit by the github outage. Only one more pass now 😬

@baronfel
Copy link
Member

baronfel commented Aug 15, 2024

yeah, the best way is to use azp run with the specific top-level job names: /azp not-run-so-things-don't-trigger dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build

@lewing lewing disabled auto-merge August 15, 2024 02:23
@lewing lewing enabled auto-merge (squash) August 15, 2024 02:24
@lewing
Copy link
Member

lewing commented Aug 15, 2024

/ba-g 🤷‍♂️

@lewing
Copy link
Member

lewing commented Aug 15, 2024

maybe @mmitche will see and take pity

@lewing lewing merged commit 3586c80 into main Aug 15, 2024
@lewing lewing deleted the darc-main-0577a9d3-017e-44fc-86f6-34647279b5dd branch August 15, 2024 07:21
@lewing lewing restored the darc-main-0577a9d3-017e-44fc-86f6-34647279b5dd branch August 16, 2024 17:57
@lewing lewing deleted the darc-main-0577a9d3-017e-44fc-86f6-34647279b5dd branch August 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.