-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[main] Update dependencies from dotnet/runtime #42688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…0812.13 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-rc.1.24410.5 -> To Version 9.0.0-rc.1.24412.13
Notification for subscribed users from https://github.com/dotnet/runtime:@dotnet/dnr-codeflow Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
Notification for subscribed users from https://github.com/dotnet/runtime:@dotnet/dnr-codeflow Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
…0813.14 Microsoft.Bcl.AsyncInterfaces , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Console , Microsoft.NET.HostModel , Microsoft.NET.ILLink.Tasks , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.Win32.SystemEvents , System.CodeDom , System.Composition.AttributedModel , System.Composition.Convention , System.Composition.Hosting , System.Composition.Runtime , System.Composition.TypedParts , System.Configuration.ConfigurationManager , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encoding.CodePages , System.Text.Json , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0 , VS.Redist.Common.NetCore.TargetingPack.x64.9.0 , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-rc.1.24412.13 -> To Version 9.0.0-rc.1.24413.14
|
cc @jozkee - the build errors look to be related to dotnet/runtime#106360. |
|
@AaronRobinsonMSFT or @agocke - do you know if something changed in InlineArrayAsReadOnlySpan that might impact the following? /vmr/src/sdk/src/Installer/redist-installer/targets/BundledTemplates.targets(4,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "CalculateTemplateVersions" task failed unexpectedly. |
|
@dotnet/domestic-cat - could this be coming from an SDK change? (See previous comment.) |
This PR doesn't really have any SDK changes, and other PRs that came out afterwards aren't failing with this, so I'm pretty sure it's from a runtime change, most likely dotnet/runtime#106360 as eerhardt suggested. Since it's trying to load it from System.Runtime, that suggests to me that it probably sees the ref assembly, then goes to the real assembly and can't find it. I'm not sure what to do about that, though. Wait for it to resolve itself with a future update? Update the global.json? |
|
From the stack trace, it looks like this is a build task that is somehow being compiled against the live runtime, but run against stock MSBuild. Presumably the problem is "build task compiled against the live runtime." I don't know how to fix that -- this would require a deeper investigation and potentially some infrastructure re-architecture. |
|
Yeah, this task is compiled against live refs, but then run on the toolset runtime. Let me see if I can determine how it gets it's references. |
|
It's this project: https://github.com/dotnet/sdk/blob/f6b5eb1c6031d05627f62c2a052dea206fd56ea6/src/Installer/core-sdk-tasks/core-sdk-tasks.csproj Seems like it needs a similar exclusion here: Lines 46 to 49 in f6b5eb1
|
This needs to run on the toolset runtime, so it should not compile against the live targeting pack.
|
I added a patch for the WPF failure, there was still a build failure on the primary CI job for OSX: Let's see if it repros. |
I've been seeing that in some other branches (and sometimes for linux); when I rerun, it goes away. Probably worth more investigation than that at some point or at least filing a known issue. |
|
I have a theory here about what's happening. Test crosstalk. One test creates that file in a shared directory, then deletes it, meanwhile some other test is running a publish and sees the file, and it's deleted before it can run copy. Do you have a log file of the failure? AzDo helpfully deleted this one since the build was cancelled 😖 |
src/SourceBuild/patches/wpf/0001-Add-references-needed-by-Formatters.Nrbf.patch
Show resolved
Hide resolved
Unfortunately no |
I saw it mentioned in all of these, but none have logs: https://github.com/dotnet/sdk/pulls?q=is%3Apr+%22because+it+was+not+found%22+is%3Aclosed+tmp Next time you see it, try to ascertain which things are running concurrently (bin log or test logs might give enough hint) and see if they are sharing the same directory. Fix is likely just to make those not run concurrently, or use unique directories. |
Omit the portion of the warning that's not stable
| "ILLink : Trim analysis warning IL2026: System.ComponentModel.TypeDescriptor.NodeFor(Object, Boolean): Using member 'System.ComponentModel.TypeDescriptor.ComObjectType.get' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. COM type descriptors are not trim-compatible.", | ||
| "ILLink : Trim analysis warning IL2026: System.ComponentModel.AmbientValueAttribute.AmbientValueAttribute(Type, String): Using member 'System.ComponentModel.AmbientValueAttribute.<.ctor>g__TypeDescriptorGetConverter|1_0(Type)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. AmbientValueAttribute usage of TypeConverter is not compatible with trimming.", | ||
| "ILLink : Trim analysis warning IL2026: System.ComponentModel.DefaultValueAttribute.DefaultValueAttribute(Type, String): Using member 'System.ComponentModel.DefaultValueAttribute.<.ctor>g__TryConvertFromInvariantString|5_0(Type, String, Object&)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. DefaultValueAttribute usage of TypeConverter is not compatible with trimming." | ||
| "ILLink : Trim analysis warning IL2026: System.ComponentModel.AmbientValueAttribute.AmbientValueAttribute(Type, String): Using member", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These warnings can be partial matches, have a look at all the others in the same test. The content of the warning changed because we modified the class layout of this type which changed the <.ctor>g__TypeDescriptorGetConverter|1_0(Type) to <.ctor>g__TypeDescriptorGetConverter|2_0(Type).
By omitting these unstable internal implementation details the test will be more maintainable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @ericstj.
|
The builds passed but for some reason badges weren't updating: I was hoping close / reopen would fix it, but instead it's requeued the builds 😭 |
they probably got hit by the github outage. Only one more pass now 😬 |
|
yeah, the best way is to use |
|
/ba-g 🤷♂️ |
|
maybe @mmitche will see and take pity |
This pull request updates the following dependencies
From https://github.com/dotnet/runtime