Pass along top-level UseSystemLibs option to runtime #41984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some environments, at least some Linux distributions, want to use system
versions of certain libraries rather than the source code copy shipped
with the .NET runtime source repository. We can provide a top-level flag
to support this scenario that can be used like this:
./build.sh -p:UseSystemLibs=brotli+libunwind+rapidjson+zlib
Which makes the VMR build the runtime repo such that it uses the system
version of brotli, libunwind, rapidjson and zlib.
This is another attempt at
dotnet/installer#19640
It depends on dotnet/runtime#104440 to work.
ghost
added
3 tasks
|
@jkotas @akoeplinger please take a look. Does such a generic switch make sense? |
|
It looks fine to me. |
ViktorHofer
approved these changes
Jul 8, 2024
|
LGTM though we could probably make it a top-level build.sh option like Does it also make sense to support the plain argument to default all libs to come from system so the distros don't need to chase adding new ones when we add new dependencies? |
akoeplinger
approved these changes
Jul 8, 2024
akoeplinger
pushed a commit
to dotnet/runtime
that referenced
this pull request
Jul 8, 2024
This will be used by dotnet/sdk#41984 It's another attempt at #101797
omajid
added a commit
to omajid/dotnet-sdk
that referenced
this pull request
Jul 11, 2024
This lets users build the VMR with a top-level flag like this:
$ /build.sh --source-only --with-system-libs brotli+libunwind+rapidjson+zlib
This was suggested during PR review at:
dotnet#41984 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments, at least some Linux distributions, want to use system versions of certain libraries rather than the source code copy shipped with the .NET runtime source repository. We can provide a top-level flag to support this scenario that can be used like this:
Which makes the VMR build the runtime repo such that it uses the system version of brotli, libunwind, rapidjson and zlib.
This is another attempt at dotnet/installer#19640
It depends on dotnet/runtime#104440 to work.