[Static Web Assets] Introduce static web asset endpoints and define compression endpoints #39636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-AspNetCore
javiercn
force-pushed
the
javiercn/static-web-assets-endpoints
branch
2 times, most recently
from
d3c0ec7 to
22e196c
Compare
javiercn
requested review from
lewing,
akoeplinger,
pavelsavara,
maraf and
a team
as code owners
|
Is there way how to test this with runtime WBT and Blazor E2E before we merge this ? |
maraf
approved these changes
Apr 3, 2024
src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.targets
Outdated
Show resolved
Hide resolved
| string assetKey = asset.ItemSpec; | ||
| assetDictionary[assetKey] = asset; | ||
| string relatedAsset = asset.GetMetadata("RelatedAsset"); | ||
| if (!string.IsNullOrEmpty(relatedAsset) && !assetDictionary.ContainsKey(relatedAsset)) |
There was a problem hiding this comment.
Should this happen in second pass over SWA in case where RelatedAsset points to a different asset? Is that possible? If not, do we need the dictionary?
javiercn
force-pushed
the
javiercn/static-web-assets-endpoints
branch
from
869c68e to
2a7ed85
Compare
javiercn
force-pushed
the
javiercn/static-web-assets-endpoints
branch
from
dc5c78f to
9fcaf87
Compare
MackinnonBuck
approved these changes
Apr 14, 2024
test/Microsoft.NET.Sdk.Razor.Tests/StaticWebAssetsBaselineComparer.cs
Outdated
Show resolved
Hide resolved
javiercn
force-pushed
the
javiercn/static-web-assets-endpoints
branch
3 times, most recently
from
8792704 to
b0b30c9
Compare
javiercn
force-pushed
the
javiercn/static-web-assets-endpoints
branch
from
b0b30c9 to
04f22f6
Compare
javiercn
force-pushed
the
javiercn/static-web-assets-endpoints
branch
from
fe7a3a2 to
97b346e
Compare
1 task
|
@javiercn @maraf this PR introduces I now have same problem with I wonder if we have good excuse for not testing changes in those files and if I could use the same excuse. Or is this a GOTCHA ? I filled dotnet/runtime#115646 to unblock myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.