Revert "[release/3.1.1xx] Update dependencies from dotnet/arcade" #3798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
dsplaisted
approved these changes
Oct 25, 2019
Member
|
Was it intentional that we weren't automatically getting arcade updates? I triggered the subscription manually to update it. |
Member
Author
|
I think the intention in 3.x is to have arcade updates be on-demand. The latest 3.x arcade has a change that inserts a package icon into our .nupkg's, which I guess needed some tweaking in SDK for us to react to correctly. It's probably a quick fix, but I don't want to risk iterating on it given the schedule for preview2. We can probably make it work easily for preview3. |
wtgodbe
deleted the
revert-3795-darc-release/3.1.1xx-eae9d768-62bc-4c54-8acd-26593dcc9e62
branch
rainersigwald
pushed a commit
that referenced
this pull request
Jul 20, 2020
…207.3 (#3798) - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19607.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package icon aspect of the Arcade update broke CLI/Toolset: https://dev.azure.com/dnceng/public/_build/results?buildId=402816, https://dev.azure.com/dnceng/public/_build/results?buildId=402815. Reverting this so we can get a 3.1-preview2 build over the weekend.