Skip to content

[main] Update dependencies from nuget/nuget.client #36063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2023
Merged

[main] Update dependencies from nuget/nuget.client #36063

merged 2 commits into from
Oct 12, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

From https://github.com/nuget/nuget.client

  • Subscription: fcb199f6-ff33-44a0-f3ef-08d8e97c775d
  • Build: 6.9.0.13
  • Date Produced: October 11, 2023 7:03:26 PM UTC
  • Commit: 5ce332fb834feea1f6c974d17456c8c9d5504e09
  • Branch: dev

@dotnet-maestro
Update dependencies from https://github.com/nuget/nuget.client build …
d96a61e 
…6.9.0.13

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.8.0-rc.122 -> To Version 6.9.0-preview.1.13
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Oct 12, 2023
@ViktorHofer
Copy link
Member

@marcpopMSFT this update requires updating the min msbuild version.

@marcpopMSFT
Copy link
Member

Hmm, we haven't historically had patch versions in the minimum msbuild, I think this is a side affect of us trying to automate the msbuild version from the minimum version here:

sdk/eng/Versions.props

Line 111 in f99001a

<MicrosoftBuildPackageVersion Condition="exists('$(RepoRoot)\src\Layout\redist\minimumMSBuildVersion') and '$(DotNetBuildFromSource)' != 'true'">$([System.IO.File]::ReadAllText('$(RepoRoot)\src\Layout\redist\minimumMSBuildVersion').Trim())</MicrosoftBuildPackageVersion>

In prior releases, I think we've just hardcoded a different version in the versions.props file. @rainersigwald any suggest that doesn't have this updating every time msbuild updates (And nuget takes an update)?

@rainersigwald
Copy link
Member

Hm. So with the new early-lockdown-for-VS approach we generally don't publish the .0 package to standard feeds. 17.7.2 is our "first GA 17.7 version". I think moving to that even in minimumMSBuildVersion makes sense--it shouldn't exclude any customers running 17.7.

@marcpopMSFT
Copy link
Member

Ahh, this was the GA released version. Makes sense then.

@dotnet-maestro dotnet-maestro bot merged commit fdb372b into main Oct 12, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-fc5d5e87-95bd-4333-9819-7f91bc022dab branch October 12, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcpopMSFT marcpopMSFT marcpopMSFT approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorHofer @marcpopMSFT @rainersigwald @Forgind