Skip to content

Change the assertion to not to catch the RAR warning #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Change the assertion to not to catch the RAR warning #3509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Tests/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildADesktopLibrary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ public void It_uses_hintpath_when_replacing_simple_name_references(bool useFacad
.Should().Be(correctHttpReference);
}

[FullMSBuildOnlyFact]
[Fact]
public void It_tolerates_newline_in_hint_path()
{
string hintPath = BuildReferencedBuildAndReturnOutputDllPath();
Expand Down Expand Up @@ -417,7 +417,7 @@ public void It_tolerates_newline_in_hint_path()
var buildCommand = new BuildCommand(Log, Path.Combine(testAsset.TestRoot, project.Name));
var msbuildBuildCommand = new MSBuildCommand(Log, "Build", buildCommand.FullPathProjectFile);
msbuildBuildCommand.Execute().Should().Pass()
.And.NotHaveStdOutContaining("Illegal characters in path");
.And.NotHaveStdOutContaining("System.ArgumentException");
}

private string BuildReferencedBuildAndReturnOutputDllPath()
Expand Down