Do not use apphost when resolving assets for dotnet store #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes in the way apphost is handled broke the case where you use an exe project as the dotnet store "manifest" project. The fix is to set UseAppHost=false when doing the store resolution.
peterhuene
approved these changes
Jul 23, 2019
dsplaisted
approved these changes
Jul 23, 2019
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
….1 (dotnet#3448) - Microsoft.DotNet.Cli.Runtime - 3.1.100-preview3.19553.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes in the way apphost is handled broke the case where you
use an exe project as the dotnet store "manifest" project.
The fix is to set UseAppHost=false when doing the store resolution.
Fix #3168