Skip to content

Workaround issue with explicitly implemented indexers #34318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jul 28, 2023

Fixes #31570

This is very similar to the fix first proposed by @andriipatsula in #31628, thank you for that!

@ericstj ericstj requested a review from ViktorHofer July 28, 2023 22:51
@ericstj ericstj requested review from andriipatsula and a team as code owners July 28, 2023 22:51
@ghost ghost added Area-GenAPI untriaged Request triage from a team member labels Jul 28, 2023
@ericstj
Copy link
Member Author

ericstj commented Jul 28, 2023

This would be safe to add for now. I think a better fix would be in roslyn, at the ISymbol layer but we'll see what they say.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ViktorHofer ViktorHofer merged commit dff005c into dotnet:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-GenAPI untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenAPI incorrectly generates collection-based interface implementation
2 participants