Fix unhandled exception when RuntimeList.xml contains duplicates. #3393
+274
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhuene
commented
Jul 4, 2019
dsplaisted
approved these changes
Jul 8, 2019
peterhuene
force-pushed
the
fix-unhandled-exceptions-from-runtime-list-errors
branch
from
988ea79 to
c1e1b0d
Compare
added 2 commits
July 15, 2019 14:43
This commit fixes an unhandled exception that results when RuntimeList.xml contains entries that have the same destination subpath when resolving the runtime pack assets. An error is now emitted instead of the unhandled exception. Additionally, this fixes an unhandled exception that occurs when the RuntimeList.xml file is not present in the runtime pack that is caused by the exception message not having a NETSDK prefix. Also removed an unnecessary override of the `Execute` method for `GenerateDepsFile` task. This override should have been removed with a previous cleanup PR, but was overlooked. Fixes dotnet/cli#11705.
This commit changes the link in the error messages to an aka.ms link.
peterhuene
force-pushed
the
fix-unhandled-exceptions-from-runtime-list-errors
branch
from
c1e1b0d to
73e0316
Compare
nguerrera
approved these changes
Jul 15, 2019
src/Tasks/Microsoft.NET.Build.Tasks/ResolveRuntimePackAssets.cs
Outdated
Show resolved
Hide resolved
This commit makes the hash set that is tracking the asset sub-paths resolved from runtime packs case-insensitive.
Contributor
Author
|
Waiting on some feedback from @KathleenDollard before merging. |
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…030.15 (dotnet#3393) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19530.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an unhandled exception that results when RuntimeList.xml
contains entries that have the same destination subpath when resolving the
runtime pack assets. An error is now emitted instead of the unhandled
exception.
Additionally, this fixes an unhandled exception that occurs when the
RuntimeList.xml file is not present in the runtime pack that is caused by
the exception message not having a NETSDK prefix.
Also removed an unnecessary override of the
Executemethod forGenerateDepsFiletask. This override should have been removed with aprevious cleanup PR, but was overlooked.
Fixes dotnet/cli#11705.