Skip to content

[release/6.0.4xx] Backport '[Blazor WASM] Don't apply hot reload deltas if Blazor has not been initialized' #33160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[release/6.0.4xx] Backport '[Blazor WASM] Don't apply hot reload deltas if Blazor has not been initialized' #33160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions src/BuiltInTools/BrowserRefresh/WebSocketScriptInjection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,20 +131,25 @@ setTimeout(async function () {
}

let applyFailed = false;
deltas.forEach(d => {
try {
window.Blazor._internal.applyHotReload(d.moduleId, d.metadataDelta, d.ilDelta, d.pdbDelta)
} catch (error) {
console.warn(error);
applyFailed = true;
}
});
if (window.Blazor?._internal?.applyHotReload) {
// Only apply hot reload deltas if Blazor has been initialized.
// It's possible for Blazor to start after the initial page load, so we don't consider skipping this step
// to be a failure. These deltas will get applied later, when Blazor completes initialization.
deltas.forEach(d => {
try {
window.Blazor._internal.applyHotReload(d.moduleId, d.metadataDelta, d.ilDelta, d.pdbDelta)
} catch (error) {
console.warn(error);
applyFailed = true;
}
});
}

fetch('/_framework/blazor-hotreload', { method: 'post', headers: { 'content-type': 'application/json' }, body: JSON.stringify(deltas) })
.then(response => {
if (response.status == 200) {
const etag = response.headers['etag'];
window.sessionStorage.setItem('blazor-webasssembly-cache', { etag, deltas });
window.sessionStorage.setItem('blazor-webassembly-cache', { etag, deltas });
}
});

Expand Down