Fix P/Invoke signatures for the resource updater. #3310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource updater was not specifying a CharSet for the Windows API P/Invoke signatures and therefore the ANSI versions of the APIs were being used. This caused an unhandled exception when customizing the apphost on Windows when the intermediate apphost path contained Unicode characters because the ANSI resource updating API couldn't find the file. Fixes AB#900429.
wli3
approved these changes
Jun 6, 2019
nguerrera
approved these changes
Jun 6, 2019
wli3
pushed a commit
to wli3/core-setup
that referenced
this pull request
Jul 24, 2019
Port dotnet/sdk#3310 by @peterhuene The resource updater was not specifying a CharSet for the Windows API P/Invoke signatures and therefore the ANSI versions of the APIs were being used. This caused an unhandled exception when customizing the apphost on Windows when the intermediate apphost path contained Unicode characters because the ANSI resource updating API couldn't find the file. Fixes AB#900429.
wli3
pushed a commit
to wli3/core-setup
that referenced
this pull request
Jul 25, 2019
Port dotnet/sdk#3310 by @peterhuene The resource updater was not specifying a CharSet for the Windows API P/Invoke signatures and therefore the ANSI versions of the APIs were being used. This caused an unhandled exception when customizing the apphost on Windows when the intermediate apphost path contained Unicode characters because the ANSI resource updating API couldn't find the file. Fixes AB#900429.
dsplaisted
pushed a commit
to dsplaisted/sdk
that referenced
this pull request
Feb 19, 2020
…024.2 (dotnet#3310) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19524.2
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Port dotnet/sdk#3310 by @peterhuene The resource updater was not specifying a CharSet for the Windows API P/Invoke signatures and therefore the ANSI versions of the APIs were being used. This caused an unhandled exception when customizing the apphost on Windows when the intermediate apphost path contained Unicode characters because the ANSI resource updating API couldn't find the file. Fixes ABdotnet/core-setup#900429. Commit migrated from dotnet/core-setup@0059721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource updater was not specifying a CharSet for the Windows API
P/Invoke signatures and therefore the ANSI versions of the APIs were
being used.
This caused an unhandled exception when customizing the apphost on
Windows when the intermediate apphost path contained Unicode characters
because the ANSI resource updating API couldn't find the file.
Fixes AB#900429.