Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about version/distro-specific RID assets in .NET 8+ #32970

Merged
merged 8 commits into from
Jun 10, 2023
Merged

Add warning about version/distro-specific RID assets in .NET 8+ #32970

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fcd2609
Add warning about version/distro-specific RID assets in .NET 8+
elinor-fung May 30, 2023
b24270c
Delete test asset directory
elinor-fung Jun 1, 2023
f3fe530
Use identifer when creating test assets
elinor-fung Jun 1, 2023
5c84bf4
Switch to expecting RID platform values to exist via BundledVersions …
elinor-fung Jun 3, 2023
abab079
Make ProcessFrameworkReferences output KnownRuntimeIdentifierPlatforms
elinor-fung Jun 8, 2023
6c43d1f
Apply suggestions from code review
elinor-fung Jun 9, 2023
5e419e7
Update src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs
elinor-fung Jun 9, 2023
2f1d006
Fix nullable
elinor-fung Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,4 +924,8 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1204: Ahead-of-time compilation is not supported on the current platform '{0}'.</value>
<comment>{StrBegin="NETSDK1204: "}</comment>
</data>
<data name="NonPortableRuntimeIdentifierDetected" xml:space="preserve">
<value>NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aka.ms link should be created before merging this PR. It can point to this PR or the design doc or something similar for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Currently points to the breaking change notice.

<comment>{StrBegin="NETSDK1205: "}</comment>
</data>
</root>
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: Projekty C++/CLI cílené na rozhraní .NET Core nemůžou používat SelfContained=true.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonPortableRuntimeIdentifierDetected">
<source>NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</source>
<target state="new">NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</target>
<note>{StrBegin="NETSDK1205: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable. For more information, see https://aka.ms/netsdk1151</source>
<target state="translated">NETSDK1151: odkazovaný projekt {0} je samostatně obsažený spustitelný soubor. Na samostatně obsažený spustitelný soubor se nedá odkazovat pomocí spustitelného souboru, který není samostatně obsažený. Další informace najdete na https://aka.ms/netsdk1151</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: C++-/CLI-Projekte für .NET Core können "SelfContained=true" nicht verwenden.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonPortableRuntimeIdentifierDetected">
<source>NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</source>
<target state="new">NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</target>
<note>{StrBegin="NETSDK1205: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable. For more information, see https://aka.ms/netsdk1151</source>
<target state="translated">NETSDK1151: Das referenzierte Projekt „{0}“ ist eine eigenständige ausführbare Datei. Auf eine eigenständige ausführbare Datei kann nicht von einer nicht eigenständigen ausführbaren Datei verwiesen werden. Weitere Informationen finden Sie unter https://aka.ms/netsdk1151.</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: Los proyectos de C++/CLI destinados a .NET Core no pueden usar SelfContained=true.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonPortableRuntimeIdentifierDetected">
<source>NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</source>
<target state="new">NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</target>
<note>{StrBegin="NETSDK1205: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable. For more information, see https://aka.ms/netsdk1151</source>
<target state="translated">NETSDK1151: El proyecto al que se hace referencia '{0}' es un ejecutable independiente. Un ejecutable independiente no puede hacer referencia a un no ejecutable independiente. Para obtener más información, consulte https://aka.ms/netsdk1151</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,11 @@ The following are names of parameters or literal values and should not be transl
<target state="translated">NETSDK1121: les projets C++/CLI qui ciblent le .NET Core ne peuvent pas utiliser SelfContained=true.</target>
<note>{StrBegin="NETSDK1121: "}</note>
</trans-unit>
<trans-unit id="NonPortableRuntimeIdentifierDetected">
<source>NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</source>
<target state="new">NETSDK1205: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</target>
<note>{StrBegin="NETSDK1205: "}</note>
</trans-unit>
<trans-unit id="NonSelfContainedExeCannotReferenceSelfContained">
<source>NETSDK1151: The referenced project '{0}' is a self-contained executable. A self-contained executable cannot be referenced by a non self-contained executable. For more information, see https://aka.ms/netsdk1151</source>
<target state="translated">NETSDK1151: le projet référencé « {0} » est un exécutable autonome. Un exécutable autonome ne peut pas être référencé par un exécutable non autonome. Pour plus d’informations, voir https://aka.ms/netsdk1151</target>
Expand Down
Loading