Skip to content

MSBuild on .NET 7: Downgrade compile-time references #28079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

rainersigwald
Copy link
Member

@rainersigwald rainersigwald commented Sep 21, 2022

Update to an MSBuild build that targets net7.0, but don't use it at SDK compile time any more, pinning to the old version we claim to support.

dotnet-maestro bot and others added 4 commits September 19, 2022 12:56
…0919.1

Microsoft.Build , Microsoft.Build.Localization
 From Version 17.4.0-preview-22466-03 -> To Version 17.4.0-preview-22469-01
…0919.2

Microsoft.Build , Microsoft.Build.Localization
 From Version 17.4.0-preview-22466-03 -> To Version 17.4.0-preview-22469-02
…0919.4

Microsoft.Build , Microsoft.Build.Localization
 From Version 17.4.0-preview-22466-03 -> To Version 17.4.0-preview-22469-04
@ghost
Copy link

ghost commented Sep 21, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@rainersigwald rainersigwald force-pushed the net7-msbuild-downgrade-everything branch from 877507f to 4a4afde Compare September 21, 2022 15:22
Always referencing the latest MSBuild means that some things like the
SDK resolver would be forced to target MSBuild's latest runtime, and
that would break compat with uses. For instance, VSMac is currently on
.NET 6.0 and can't run a net7.0 resolver.

We do, however, want to always _ship_ the latest MSBuild.
@rainersigwald rainersigwald force-pushed the net7-msbuild-downgrade-everything branch from 4a4afde to 8760460 Compare September 21, 2022 15:48
@rainersigwald rainersigwald marked this pull request as ready for review September 21, 2022 18:07
@rainersigwald rainersigwald merged commit a5274e4 into release/7.0.1xx Sep 21, 2022
@rainersigwald rainersigwald deleted the net7-msbuild-downgrade-everything branch September 21, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants