-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[main] Update dependencies from microsoft/vstest #26696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from microsoft/vstest #26696
Conversation
…220719-01 Microsoft.NET.Test.Sdk From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220719-01
Notification for subscribed users from https://github.com/microsoft/vstest:@Haplois @cvpoienaru @MarcoRossignoli @Evangelink Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.
|
…220720-01 Microsoft.NET.Test.Sdk From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220720-01
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…220721-02 Microsoft.NET.Test.Sdk From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220721-02
@ericstj @dotnet/area-infrastructure-libraries @joperezr the packageinstall tests appear to be having some issues in recent runs: We did make a recent change to add an additional local nuget cache during test runs but that PR passed these tests so not sure why it would be sometimes causing issues. |
@marcpopMSFT the package install tests aren't something that our team owns. You might be mixing this up with package validation / apicompat which we own. |
…220722-02 Microsoft.NET.Test.Sdk From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220722-02
@ViktorHofer thanks for the clarification. You're right, in my head both PackageInstall and PackageValidation were the same group of tests. |
I put out what I think is a fix that should help with the PackageInstall tests that seem to have an issue with the new nuget caching I put into place: @pavelhorak @nohwnd there still appears to be a real issue in this insertion. While investigating the above, I noticed that this test failed separately from the other issues: Microsoft.DotNet.Cli.Test.Tests.GivenDotnetTestBuildsAndRunsTestFromCsprojForMultipleTFM.MStestMultiTFM In running the test, what I'm seeing is that the netfx TFM isn't running tests. I found that by updating to net462, the test works. Can I assume that this is a by design change since 46 went out of support, dotnet test no longer supports it either? I would add that the error experience wasn't great (it just silently failed to run those tests and it may be worth considering providing the customer an explanation). I went ahead and updated the test to 462 for now to unblock the PR. |
… not working with dotnet test anymore
…s://github.com/dotnet/sdk into darc-main-ca2fc4a7-5e0c-457c-a41d-f1024a505df1
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…220722-05 Microsoft.NET.Test.Sdk From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220722-05
This pull request updates the following dependencies
From https://github.com/microsoft/vstest