Skip to content

[main] Update dependencies from microsoft/vstest #26696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 25, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 19, 2022

This pull request updates the following dependencies

From https://github.com/microsoft/vstest

  • Subscription: cfdc40e1-67c8-4116-5637-08d9e1012aa9
  • Build: 20220722-05
  • Date Produced: July 22, 2022 3:33:05 PM UTC
  • Commit: c4f8e9de2c4f6622586a9cd240ea03873da7d331
  • Branch: refs/heads/main

…220719-01

Microsoft.NET.Test.Sdk
 From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220719-01
@ghost ghost added the Area-dotnet test label Jul 19, 2022
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/microsoft/vstest:

@Haplois @cvpoienaru @MarcoRossignoli @Evangelink

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/microsoft/vstest) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@Evangelink Evangelink enabled auto-merge July 19, 2022 16:59
…220720-01

Microsoft.NET.Test.Sdk
 From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220720-01
@v-wuzhai
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…220721-02

Microsoft.NET.Test.Sdk
 From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220721-02
@marcpopMSFT
Copy link
Member

@ericstj @dotnet/area-infrastructure-libraries @joperezr the packageinstall tests appear to be having some issues in recent runs: Microsoft.DotNet.ToolPackage.ToolPackageException : The tool package could not be restored.

We did make a recent change to add an additional local nuget cache during test runs but that PR passed these tests so not sure why it would be sometimes causing issues.

#26748
#26749

@ViktorHofer
Copy link
Member

@ericstj https://github.com/orgs/dotnet/teams/area-infrastructure-libraries @joperezr the packageinstall tests appear to be having some issues in recent runs: Microsoft.DotNet.ToolPackage.ToolPackageException : The tool package could not be restored.

@marcpopMSFT the package install tests aren't something that our team owns. You might be mixing this up with package validation / apicompat which we own.

…220722-02

Microsoft.NET.Test.Sdk
 From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220722-02
@marcpopMSFT
Copy link
Member

@ViktorHofer thanks for the clarification. You're right, in my head both PackageInstall and PackageValidation were the same group of tests.

@marcpopMSFT
Copy link
Member

I put out what I think is a fix that should help with the PackageInstall tests that seem to have an issue with the new nuget caching I put into place:
#26764

@pavelhorak @nohwnd there still appears to be a real issue in this insertion. While investigating the above, I noticed that this test failed separately from the other issues: Microsoft.DotNet.Cli.Test.Tests.GivenDotnetTestBuildsAndRunsTestFromCsprojForMultipleTFM.MStestMultiTFM

In running the test, what I'm seeing is that the netfx TFM isn't running tests. I found that by updating to net462, the test works. Can I assume that this is a by design change since 46 went out of support, dotnet test no longer supports it either? I would add that the error experience wasn't great (it just silently failed to run those tests and it may be worth considering providing the customer an explanation).

I went ahead and updated the test to 462 for now to unblock the PR.

@marcpopMSFT
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…220722-05

Microsoft.NET.Test.Sdk
 From Version 17.4.0-preview-20220715-02 -> To Version 17.4.0-preview-20220722-05
@Evangelink Evangelink merged commit 807c9a9 into main Jul 25, 2022
@Evangelink Evangelink deleted the darc-main-ca2fc4a7-5e0c-457c-a41d-f1024a505df1 branch July 25, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants