Update the wasm install to skip manifest updates #24958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing workloads using our build feeds, we have to either use a rollback file or skip manifest updates. Otherwise, we'll be installing live builds of those manifests which may not work.
ghost
added
the
TanayParikh
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
LGTM if CI passes. I'd tried this earlier (#22977), however it led to a bunch of stale packages being used.
Edit: Maybe that was because of --no-cache.
|
@TanayParikh It'll use whatever versions of the workloads are included in the SDK that's in global.json I believe. Do you need more up to date versions? If so, have you looked into using |
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing workloads using our build feeds, we have to either use a rollback file or skip manifest updates. Otherwise, we'll be installing live builds of those manifests which may not work.