Skip to content

Conversation

@marcpopMSFT
Copy link
Member

No description provided.

@ghost
Copy link

ghost commented Aug 17, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@marcpopMSFT marcpopMSFT added the Branding Tracking branding updates across our repos label Aug 17, 2021
@wli3 wli3 force-pushed the marcpopMSFT-brandingfor7.0 branch from fb2436d to 7500675 Compare August 19, 2021 15:30
@wli3 wli3 enabled auto-merge August 19, 2021 17:55
@wli3
Copy link

wli3 commented Aug 19, 2021

depend on #19902

@marcpopMSFT
Copy link
Member Author

retriggering the merge

auto-merge was automatically disabled August 19, 2021 21:44

Pull request was closed

@marcpopMSFT marcpopMSFT reopened this Aug 19, 2021
@mmitche
Copy link
Member

mmitche commented Aug 20, 2021

We probably need an update from dotnet/installer into this repo before this will pass, and dotnet/installer actually needs an update from dotnet/sdk in order to build against the 7.0 templates. I think I worked around this in installer. We'll see.

@marcpopMSFT
Copy link
Member Author

Given the list of failures, we actually don't need an updated installer per se. The dotnet watch tests are fixed by the global.json update that Pranav already did. The 3 workload failures require the fallback logic to be enabled which was turned on in rc2: dotnet/installer#11571. So we either need to disable those, port that change and update global.json, or workaround it in the tests. The remaining tests I've pinged Daniel on as it's searching the 6.0.100 manifests when trying to resolve packs for some reason (ie if I push the test manifest into a 6.0.100 directory, the tests pass).

… rely on workload fallback and so need a newer SDK.
@marcpopMSFT marcpopMSFT force-pushed the marcpopMSFT-brandingfor7.0 branch from 7500675 to 8d8b6ed Compare August 24, 2021 21:15
@marcpopMSFT
Copy link
Member Author

SDK tests are now passing but dotnet watch tests are failing. @mkArtakMSFT do you have someone available that can take a look at them? This PR updates branding and global.json only but a bunch of dotnet watch tests are failing with nullrefs which from code, I assume is definedTypesMessage being null.

Error message
System.NullReferenceException : Object reference not set to an instance of an object.

Stack trace
at Microsoft.DotNet.Watcher.Tools.GlobbingAppTests.GetCompiledAppDefinedTypes(WatchableApp app) in //src/Tests/dotnet-watch.Tests/GlobbingAppTests.cs:line 166
at Microsoft.AspNetCore.Testing.TaskExtensions.TimeoutAfter[T](Task`1 task, TimeSpan timeout, String filePath, Int32 lineNumber) in /
/src/Tests/dotnet-watch.Tests/Utilities/TaskExtensions.cs:line 22
at Microsoft.DotNet.Watcher.Tools.GlobbingAppTests.DeleteSourceFolder() in /_/src/Tests/dotnet-watch.Tests/GlobbingAppTests.cs:line 88
--- End of stack trace from previous location ---

@marcpopMSFT
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@marcpopMSFT marcpopMSFT closed this Sep 7, 2021
@mmitche mmitche deleted the marcpopMSFT-brandingfor7.0 branch October 4, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Branding Tracking branding updates across our repos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants