-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update Versions.props for 7.0 branding #19800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
fb2436d to
7500675
Compare
|
depend on #19902 |
|
retriggering the merge |
|
We probably need an update from dotnet/installer into this repo before this will pass, and dotnet/installer actually needs an update from dotnet/sdk in order to build against the 7.0 templates. I think I worked around this in installer. We'll see. |
|
Given the list of failures, we actually don't need an updated installer per se. The dotnet watch tests are fixed by the global.json update that Pranav already did. The 3 workload failures require the fallback logic to be enabled which was turned on in rc2: dotnet/installer#11571. So we either need to disable those, port that change and update global.json, or workaround it in the tests. The remaining tests I've pinged Daniel on as it's searching the 6.0.100 manifests when trying to resolve packs for some reason (ie if I push the test manifest into a 6.0.100 directory, the tests pass). |
… rely on workload fallback and so need a newer SDK.
7500675 to
8d8b6ed
Compare
|
SDK tests are now passing but dotnet watch tests are failing. @mkArtakMSFT do you have someone available that can take a look at them? This PR updates branding and global.json only but a bunch of dotnet watch tests are failing with nullrefs which from code, I assume is definedTypesMessage being null. Error message Stack trace |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
No description provided.