Skip to content

Add MetadataUpdaterSupport property #18670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Add MetadataUpdaterSupport property #18670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions src/Assets/TestProjects/KitchenSink/TestApp/TestApp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,33 @@
<EnableDefaultItems>false</EnableDefaultItems>
</PropertyGroup>

<!-- Host configuration properties -->
<!-- Host configuration properties
Keep this list in the same order as the configProperties in GivenThatWeWantToPublishAProjectWithAllFeatures. -->
<PropertyGroup>
<EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization>false</EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization>
<DebuggerSupport>true</DebuggerSupport>
<EventSourceSupport>false</EventSourceSupport>
<InvariantGlobalization>true</InvariantGlobalization>
<ConcurrentGarbageCollection>false</ConcurrentGarbageCollection>
<ServerGarbageCollection>true</ServerGarbageCollection>
<RetainVMGarbageCollection>false</RetainVMGarbageCollection>
<ThreadPoolMinThreads>2</ThreadPoolMinThreads>
<ThreadPoolMaxThreads>9</ThreadPoolMaxThreads>
<InvariantGlobalization>true</InvariantGlobalization>
<HttpActivityPropagationSupport>false</HttpActivityPropagationSupport>
<UseNativeHttpHandler>true</UseNativeHttpHandler>
<MetadataUpdaterSupport>false</MetadataUpdaterSupport>
<CustomResourceTypesSupport>false</CustomResourceTypesSupport>
<UseSystemResourceKeys>true</UseSystemResourceKeys>
<BuiltInComInteropSupport>false</BuiltInComInteropSupport>
<_EnableConsumingManagedCodeFromNativeHosting>false</_EnableConsumingManagedCodeFromNativeHosting>
<EnableCppCLIHostActivation>false</EnableCppCLIHostActivation>
<EnableUnsafeBinaryFormatterSerialization>false</EnableUnsafeBinaryFormatterSerialization>
<TieredCompilation>true</TieredCompilation>
<TieredCompilationQuickJit>true</TieredCompilationQuickJit>
<TieredCompilationQuickJitForLoops>true</TieredCompilationQuickJitForLoops>
<StartupHookSupport>false</StartupHookSupport>
<AutoreleasePoolSupport>false</AutoreleasePoolSupport>
<CustomResourceTypesSupport>false</CustomResourceTypesSupport>
<EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization>false</EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization>
<EventSourceSupport>false</EventSourceSupport>
<UseSystemResourceKeys>true</UseSystemResourceKeys>
<EnableUnsafeUTF7Encoding>false</EnableUnsafeUTF7Encoding>
<HttpActivityPropagationSupport>false</HttpActivityPropagationSupport>
<DebuggerSupport>true</DebuggerSupport>
<AutoreleasePoolSupport>false</AutoreleasePoolSupport>
<ThreadPoolMinThreads>2</ThreadPoolMinThreads>
<ThreadPoolMaxThreads>9</ThreadPoolMaxThreads>
</PropertyGroup>

<ItemGroup>
Expand Down
5 changes: 5 additions & 0 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,11 @@ Copyright (c) .NET Foundation. All rights reserved.
Value="$(UseNativeHttpHandler)"
Trim="true" />

<RuntimeHostConfigurationOption Include="System.Reflection.Metadata.MetadataUpdater.IsSupported"
Condition="'$(MetadataUpdaterSupport)' != ''"
Value="$(MetadataUpdaterSupport)"
Trim="true" />

<RuntimeHostConfigurationOption Include="System.Resources.ResourceManager.AllowCustomResourceTypes"
Condition="'$(CustomResourceTypesSupport)' != ''"
Value="$(CustomResourceTypesSupport)"
Expand Down
13 changes: 10 additions & 3 deletions src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAProjectWithAllFeatures.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,25 +63,32 @@ public void It_publishes_the_project_correctly(string targetFramework, string []
var runtimeConfigJsonContents = File.ReadAllText(Path.Combine(publishDirectory.FullName, "TestApp.runtimeconfig.json"));
var runtimeConfigJsonObject = JObject.Parse(runtimeConfigJsonContents);

// Keep this list sorted
var baselineConfigJsonObject = JObject.Parse(@"{
""runtimeOptions"": {
""configProperties"": {
""System.ComponentModel.TypeConverter.EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization"": false,
""System.Diagnostics.Debugger.IsSupported"": true,
""System.Diagnostics.Tracing.EventSource.IsSupported"": false,
""System.Globalization.Invariant"": true,
""System.GC.Concurrent"": false,
""System.GC.Server"": true,
""System.GC.RetainVM"": false,
""System.Net.Http.EnableActivityPropagation"": false,
""System.Net.Http.UseNativeHttpHandler"": true,
""System.Reflection.Metadata.MetadataUpdater.IsSupported"": false,
""System.Resources.ResourceManager.AllowCustomResourceTypes"": false,
""System.Resources.UseSystemResourceKeys"": true,
""System.Runtime.InteropServices.BuiltInComInterop.IsSupported"": false,
""System.Runtime.InteropServices.EnableConsumingManagedCodeFromNativeHosting"": false,
""System.Runtime.InteropServices.EnableCppCLIHostActivation"": false,
""System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization"": false,
""System.Runtime.TieredCompilation"": true,
""System.Runtime.TieredCompilation.QuickJit"": true,
""System.Runtime.TieredCompilation.QuickJitForLoops"": true,
""System.StartupHookProvider.IsSupported"": false,
""System.Threading.Thread.EnableAutoreleasePool"": false,
""System.Resources.ResourceManager.AllowCustomResourceTypes"": false,
""System.ComponentModel.TypeConverter.EnableUnsafeBinaryFormatterInDesigntimeLicenseContextSerialization"": false,
""System.Text.Encoding.EnableUnsafeUTF7Encoding"": false,
""System.Threading.Thread.EnableAutoreleasePool"": false,
""System.Threading.ThreadPool.MinThreads"": 2,
""System.Threading.ThreadPool.MaxThreads"": 9,
""extraProperty"": true
Expand Down