Skip to content

Revert workaround for runtimeconfig generation issue #18372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

dsplaisted
Copy link
Member

@dsplaisted dsplaisted commented Jun 18, 2021

Original commit: 150c6fa.

PR with discussion of issue and workaround: #17948

Workaround is no longer needed with #17982

The workaround seems to negatively affect the local dev experience for this repo, as you often run into locked task files when trying to build.

@ghost
Copy link

ghost commented Jun 18, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dsplaisted dsplaisted requested a review from a team June 18, 2021 19:27
@dsplaisted
Copy link
Member Author

@dotnet/msbuild @rainersigwald When I update stage 0, this is now failing with:

C:\git\dotnet-sdk\sdk.sln(2,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 2, position 1.

This is when Arcade is using the MSBuild task to build the solution file. The solution file hasn't changed, and works with dotnet build and Visual Studio. Has something changed that could impact how the MSBuild task works with solution files?

@rainersigwald
Copy link
Member

C:\git\dotnet-sdk\sdk.sln(2,1): error MSB4025: The project file could not be loaded. Data at the root level is invalid. Line 2, position 1.

This is when Arcade is using the MSBuild task to build the solution file. The solution file hasn't changed, and works with dotnet build and Visual Studio. Has something changed that could impact how the MSBuild task works with solution files?

This sounds like the "can't build solution out-of-proc" issue that @rokonec was working on. It's likely related to the NOINPROCNODE change.

@marcpopMSFT
Copy link
Member

@dsplaisted can this be closed since preview 6 is done? Does it need to be in main?

@dsplaisted
Copy link
Member Author

We should eventually try to get it into main.

…icrosoft.NETCore.App shared framework"

This reverts commit 150c6fa.

Workaround is no longer needed with dotnet#17982
@dsplaisted dsplaisted force-pushed the revert-runtimeconfig-workaround branch from 34e2e5b to 21695b8 Compare July 6, 2021 18:12
@dsplaisted dsplaisted changed the base branch from release/6.0.1xx-preview6 to main July 6, 2021 18:12
@dsplaisted dsplaisted merged commit 4f91a8e into dotnet:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants