Skip to content

SDK support for runtime native host and COM changes #17657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2021

Conversation

LakshanF
Copy link
Contributor

SDK property support for the native host (IJW & Managed Component) feature switches. Also fixed name changes for the COM feature switch

@ghost
Copy link

ghost commented May 16, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should be careful about merging this in preview5. The runtime still needs to be updated with the new names. If this change went into preview5, but the corresponding runtime change didn't, we would have mis-matches.

@LakshanF LakshanF merged commit 660b69e into dotnet:main May 20, 2021
@LakshanF LakshanF deleted the ComHostWarn branch May 20, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants