[vendored-sync] dotnet-test-wire-contract-constants: drift detected (#0)

[github-actions]

Automated drift report for vendored file src/Cli/dotnet/Commands/Test/CliConstants.cs.

Source

• Upstream repo: microsoft/testfx
• Upstream path: src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs
• Tracked ref: main
• Scope: wire constants (TestStates, SessionEventTypes, HandshakeMessage*, ProtocolConstants)

Drift

• Baseline blob SHA: d21531909dd2620f3d0f4c61190f05a82b383f44
• Current blob SHA: 8e11c4ba1b8472a4d28178f28ef088c0c0948580
• Baseline ref SHA : 1285203f4cea535b9386e0e8712b4ec078de16f2
• Current ref SHA : f935d2d3f9ce1ab831a361041b0ceaf92ff73363

Links

• File history
• Baseline blob
• Current blob
• Upstream ref compare (whole-repo diff, may be noisy)

Upstream-only diff

--- src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs@d215319
+++ src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/IPC/Constants.cs@8e11c4b
@@ -88,6 +88,13 @@
     // reports "1". This is an additive, capability-style property: consumers that do not understand it ignore it,
     // so it is not gated on the negotiated protocol version.
     internal const byte AttemptNumber = 13;
+
+    // Semicolon-separated reverse-DNS artifact kinds supported by the post-processors registered in this app.
+    // Missing means the app does not advertise artifact post-processing.
+    internal const byte SupportedPostProcessorKinds = 14;
+
+    // Semicolon-separated lowercase file extensions used as a compatibility fallback for untagged artifacts.
+    internal const byte SupportedPostProcessorExtensionsLegacy = 15;
 }
 
 [Embedded]
@@ -114,6 +121,9 @@
     // A test host orchestrator process (e.g. the retry orchestrator) that drives
     // one or more test host executions.
     internal const string TestHostOrchestrator = "TestHostOrchestrator";
+
+    // A tool host relaunched by dotnet test to run artifact post-processors.
+    internal const string ArtifactPostProcessor = "ArtifactPostProcessor";
 }
 
 [Embedded]
@@ -127,6 +137,9 @@
 
     // The host is going to discover tests (e.g. --list-tests).
     internal const string Discover = "discover";
+
+    // Artifact post-processing or another non-test tool.
+    internal const string Tool = "tool";
 }
 
 [Embedded]

Local adaptation notes

Handshake/session/state string constants for the 'dotnet test' named-pipe protocol. Upstream lives in testfx IPC/Constants.cs; the SDK inlines the same constants into CliConstants.cs (TestStates, SessionEventTypes, HandshakeMessagePropertyNames, HandshakeMessageExecutionModes, ProtocolConstants). Watch the upstream file for added/changed wire constants.

How to reconcile

1. Review the upstream changes and decide whether they should be ported.
2. Port the relevant changes to src/Cli/dotnet/Commands/Test/CliConstants.cs.
3. Update eng/vendored-files.json entry dotnet-test-wire-contract-constants (source index 0):
   • bump baseline_ref_sha to the new upstream ref SHA,
   • bump baseline_blob_sha to the new upstream blob SHA.
4. Close this issue once the reconciliation PR is merged.

If no port is needed (e.g. whitespace-only upstream change), still bump the baseline SHAs to silence future runs.

[marcpopMSFT]

@Evangelink what's up with the issues in this label? Do you have a mirror from your repo keeping certain files in sync? Why is cliconstants included in that as isn't that a central file?

[Evangelink]

Yes and no — the files really are copies of testfx source, so in that sense it is a mirror. What there isn't is any automation that syncs them: nothing pulls from testfx, and no code is ever written by a tool. What I added in e5dcfd0 is only a detector — it notices when the upstream copy has moved and files an issue so a human can decide what to do. Copying stays manual and reviewed.

Why it exists: we originally consumed the shared dotnet test ↔ Microsoft.Testing.Platform source via the source-only Microsoft.Testing.Platform.Internal.DotnetTest package (#54959), but that broke source-build/the VMR (dotnet/dotnet#7529), so we reverted to hand-copying the source. That copy lost the compile-time guarantee that both sides stay aligned, and the named-pipe wire contract fails silently at runtime if the two drift. The detector is the replacement guarantee.

How it works: .github/workflows/check-vendored-files.yml runs weekly, and .github/scripts/check_vendored_files.py compares the baseline blob SHAs recorded in eng/vendored-files.json against the current SHAs on microsoft/testfx main. When a tracked upstream file changes it opens (or updates) one tracking issue with the upstream-only diff. It never touches code and never auto-closes — a human decides whether the change needs porting. Docs: eng/vendored-files.md.

Why CliConstants.cs: only a slice of it is tracked — the wire constants (TestStates, SessionEventTypes, HandshakeMessagePropertyNames, HandshakeMessageExecutionModes, ProtocolConstants). Upstream those live in a dedicated file (ServerMode/DotnetTest/IPC/Constants.cs); on our side they were inlined into the pre-existing CliConstants.cs instead of a new file. Everything else in that file (SDK-only option keys, project properties, …) is not tracked and never triggers a report — the entry carries an explicit scope. The issue title names the file because that's where the vendored region lives. If the framing is confusing we can split the wire constants into their own file so the tracked unit matches upstream 1:1.

This particular issue: it's a stale baseline, not a real gap. The three constants upstream added (SupportedPostProcessorKinds, SupportedPostProcessorExtensionsLegacy, ArtifactPostProcessor/Tool) already exist in our copy — they came from our side with the MTP artifact post-processing work and testfx picked them up. So the fix is just bumping baseline_ref_sha/baseline_blob_sha. Same story for the other three open ones (#55472, #55473, #55474); I'll reconcile them and close.

I've also just changed the workflow so these issues get the Area-dotnet test (MTP) label going forward (and backfill it on existing ones), so they land in the normal area triage queue instead of only under area-vendored-sync.