.NET 10 SDK dotnet clean does not remove packages produced by multi-TFM projects

[adamralph]

Describe the bug

When using SDK versions 10.0.100 or 10.0.101 with projects that targets multiple TFM's, dotnet clean does not remove the packages produced by those projects. This seems like a regression, because the 9.x SDK does remove the packages.

To Reproduce

1. git clone https://github.com/adamralph/dotnet-clean-bug.git
2. cd dotnet-clean-bug/sdk-9
3. dotnet build
4. Observe that bin/Debug/test.1.0.0.nupkg is created.
5. dotnet clean
6. Observe that bin/Debug/test.1.0.0.nupkg is deleted.
7. cd ../sdk-10
8. dotnet build
9. Observe that bin/Debug/test.1.0.0.nupkg is created.
10. dotnet clean
11. Observe that bin/Debug/test.1.0.0.nupkg is NOT deleted.

Exceptions (if any)

N/A

Further technical details

details of dotnet --info

.NET SDK: Version: 10.0.101 Commit: fad253f51b Workload version: 10.0.100.1 MSBuild version: 18.0.6+fad253f51

Runtime Environment:
OS Name: Mac OS X
OS Version: 26.1
OS Platform: Darwin
RID: osx-arm64
Base Path: /usr/local/share/dotnet/sdk/10.0.101/

.NET workloads installed:
There are no installed workloads to display.
Configured to use workload sets when installing new manifests.

Host:
Version: 10.0.1
Architecture: arm64
Commit: fad253f51b

.NET SDKs installed:
8.0.204 [/usr/local/share/dotnet/sdk]
9.0.101 [/usr/local/share/dotnet/sdk]
9.0.104 [/usr/local/share/dotnet/sdk]
9.0.200 [/usr/local/share/dotnet/sdk]
9.0.203 [/usr/local/share/dotnet/sdk]
10.0.100-rc.2.25502.107 [/usr/local/share/dotnet/sdk]
10.0.100 [/usr/local/share/dotnet/sdk]
10.0.101 [/usr/local/share/dotnet/sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 8.0.4 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.2 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.3 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 9.0.4 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 10.0.0-rc.2.25502.107 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 10.0.0 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 10.0.1 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 8.0.4 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.2 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.3 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 9.0.4 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 10.0.0-rc.2.25502.107 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 10.0.0 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 10.0.1 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
None

Environment variables:
Not set

global.json file:
Not found

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

• The IDE (VS / VS Code/ VS4Mac) you're running on, and its version
  • N/A (command line)

[baronfel]

I think this is a regression in some of the dependencies in the NuGet Pack task dependencies. I took your example (thanks!) and checked out the binlogs - you can see here that the _CleanPackageFiles Target isn't Deleting anything:

In 9, the _CleanPackageFiles Target did delete things, because the _GetOutputItemsFromPack Target ran to populate a list of Items to delete. That's not happening in 10 because the PackageReferenceCompatibleProjectStyle Property isn't being set (it's part of the Condition check on _GetOutputItemsFromPack), and it isn't being set because the _GetRestoreProjectStyle Target isn't called. If I manually force that Target to get called the package is cleaned up.

It looks like that Condition check on _GetOutputItemsFromPack didn't exist in 9, but does in 10 - this will likely need to be raised over at NuGet/Home for the NuGet team to dig into the hows and whys of this change.

[adamralph]

@baronfel thanks for looking into it!

this will likely need to be raised over at NuGet/Home for the NuGet team to dig into the hows and whys of this change

Does this require any action from me?

[baronfel]

It would be ideal if you could re raise it there - we can't transfer due to GH org boundaries, and customer reports are generally more authoritative. No worries if you can't, though - I can try to get to it tomorrow.

[adamralph]

No problem, I raised it there — NuGet/Home#14681

[dotnet-policy-service]

Thanks for creating this issue! We believe this issue is related to NuGet tooling, which is maintained by the NuGet team. Thus, we closed this one and encourage you to raise this issue in the NuGet repository instead. Don’t forget to check out NuGet’s contributing guide before submitting an issue!

If you believe this issue was closed out of error, please comment to let us know.

Happy Coding!