SDK doesn't honor TargetingPackVersion on FrameworkReference

[ericstj]

SDK permits specifying TargetingPackVersion metdata on FrameworkReference:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/ResolveFrameworkReferences.cs

Lines 99 to 103 in 7d6b26d

	if (frameworkReference != null)
	{
	// Allow targeting pack version to be overridden via metadata on FrameworkReference
	targetingPackVersion = frameworkReference.GetMetadata("TargetingPackVersion");
	}

But then it constructs the path to the targeting pack based on KnownFrameworkReference:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/ResolveFrameworkReferences.cs

Lines 112 to 122 in 7d6b26d

	string targetingPackPath = null;
	if (!string.IsNullOrEmpty(TargetingPackRoot))
	{
	targetingPackPath = Path.Combine(TargetingPackRoot, knownFrameworkReference.TargetingPackName, knownFrameworkReference.TargetingPackVersion);
	}
	if (targetingPackPath != null && Directory.Exists(targetingPackPath))
	{
	// Use targeting pack from packs folder
	targetingPack.SetMetadata(MetadataKeys.PackageDirectory, targetingPackPath);
	targetingPack.SetMetadata(MetadataKeys.Path, targetingPackPath);
	}

Also, is this really the way we should be specifying which framework to build against? I had expected RuntimeFrameworkVersion to work, but it looks like that only controls the runtime and not ref-pack.

/cc @dsplaisted

[dsplaisted]

I've added a fix for this to #3111.

It is intentional that the targeting pack versions separately from the runtime version. Once we ship an RTM, the runtime will continue to be patched, but we expect to keep using the 3.0.0 version (for example) of the targeting pack unless there is a bug we need to fix with the targeting pack.

[ericstj]

I see. Did you consider a property for this, or is that not so interesting in light of multiple frameworks? /cc @natemcmaster @zsd4yr @vatsan-madhavan

[ericstj]

Looks like RuntimeFrameworkVersion alone should have been enough, so there might be another bug here since that stopped working for us (at least on Preview3 bits).

[livarcocc]

@dsplaisted is this still an issue?

[dsplaisted]

This should be fixed. RuntimeFrameworkVersion doesn't affect the targeting pack version, as once we release the runtime and the targeting packs will be patched independently.