Garbage collection output does not list the pack IDs

[mattleibow]

After the installation, the GC runs and outputs all the things it removes. Except, it just puts out version numbers:

note the double space that seems to indicate it should have been there...

Garbage collecting for SDK feature band(s) 6.0.100...
Uninstalling workload pack  version 6.0.100-rc.1.1516.
Uninstalling workload pack  version 15.0.100-rc.1.1528.
Uninstalling workload pack  version 15.0.100-rc.1.1528.
Uninstalling workload pack  version 15.0.100-rc.1.1528.
Uninstalling workload pack  version 15.0.100-rc.1.1528.
Uninstalling workload pack  version 15.0.100-rc.1.1528.
Uninstalling workload pack  version 12.0.100-rc.1.1528.
Uninstalling workload pack  version 12.0.100-rc.1.1528.
Uninstalling workload pack  version 12.0.100-rc.1.1528.
Uninstalling workload pack  version 12.0.100-rc.1.1528.
Uninstalling workload pack  version 12.0.100-rc.1.1528.
Uninstalling workload pack  version 6.0.100-rc.1.1516.
Uninstalling workload pack  version 6.0.100-rc.1.1516.

[KalleOlaviNiemitalo]

It should come from PackInfo.Id:

sdk/src/Cli/dotnet/commands/dotnet-workload/install/LocalizableStrings.resx

Lines 264 to 266 in 1f6482d

	<data name="DeletingWorkloadPack" xml:space="preserve">
	<value>Uninstalling workload pack {0} version {1}.</value>
	</data>

sdk/src/Cli/dotnet/commands/dotnet-workload/install/NetSdkManagedInstaller.cs

Line 414 in 1f6482d

_reporter.WriteLine(string.Format(LocalizableStrings.DeletingWorkloadPack, packInfo.Id, packInfo.Version));

sdk/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/WorkloadResolver.cs

Lines 585 to 588 in 24654cc

	/// <summary>
	/// The workload pack ID. The NuGet package ID <see cref="ResolvedPackageId"/> may differ from this.
	/// </summary>
	public WorkloadPackId Id { get; }

#18166 changed the type of PackInfo.Id from string to WorkloadPackId. Might that have affected the JSON format so that installation records saved by earlier versions can no longer be fully deserialized?

sdk/src/Cli/dotnet/commands/dotnet-workload/install/NetSdkManagedInstaller.cs

Lines 330 to 336 in 1f6482d

	var deletablePack = GetPackInfo(packVersionDir);
	if (deletablePack == null)
	{
	// Pack no longer exists in manifests, get pack info from installation record
	deletablePack = JsonSerializer.Deserialize(jsonPackInfo, typeof(PackInfo)) as PackInfo;
	}
	DeletePack(deletablePack);

[KalleOlaviNiemitalo]

I ran dotnet workload install wasm-tools on .NET SDK 6.0.100-preview.7.21379.14 and got a C:\Program Files\dotnet\metadata\workloads\InstalledPacks\v1\Microsoft.NET.Runtime.Emscripten.Node\6.0.0-preview.7.21377.2\6.0.100 file containing:

{"Id":{},"Version":"6.0.0-preview.7.21377.2","Kind":0,"ResolvedPackageId":"Microsoft.NET.Runtime.Emscripten.2.0.23.Node.win-x64","Path":"C:\\Program Files\\dotnet\\packs\\Microsoft.NET.Runtime.Emscripten.2.0.23.Node.win-x64\\6.0.0-preview.7.21377.2","IsStillPacked":true}

i.e. the ID string was lost already in JSON serialization and not just in deserialization. I presume this is because WorkloadPackId does not have any public properties. So if you want to use WorkloadPackId in PackInfo, then it needs JSON converters or alternative string-typed properties.

[sfoslund]

I'm not able to repro this issue with out latest build. I tried out installing/ garbage collecting android and wasm-tools packs and both showed up with the correct pack ids. @KalleOlaviNiemitalo @mattleibow can you give more details about your configuration? It looks like you're on windows using preview 7 file based installs, right? Are you seeing it with all workloads or only specific ones?

[KalleOlaviNiemitalo]

@sfoslund, I suspected that @mattleibow was hitting a JSON deserialization problem, installed wasm-tools to examine the workload "installation record" file format, and found that the "Id" property was clearly incomplete, which could explain the problem. This was with .NET SDK installed from dotnet-sdk-6.0.100-preview.7.21379.14-win-x64.exe. I have not tried other workloads. I don't know how to trigger the garbage collection itself and have not verified that the pack ID is missing from the output there.

When you install a workload, do you get this empty "Id":{} or something else?

Note also the comment

sdk/src/Cli/dotnet/commands/dotnet-workload/install/NetSdkManagedInstaller.cs

Line 333 in 1f6482d

// Pack no longer exists in manifests, get pack info from installation record

i.e. if you are testing with workload pack versions that still exist in manifests, then you won't reach this code path.

[sfoslund]

Ah, you're right, the id is empty but it wasn't repro-ing as it was going down a different code path. I have enough to investigate now, thanks!

[sfoslund]

Fixed by #20876