Start working on building a layer #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template for Dependabot updates.
Bumps [GitHubActionsTestLogger](https://github.com/Tyrrrz/GitHubActionsTestLogger) from 1.4.1 to 2.0.1. - [Release notes](https://github.com/Tyrrrz/GitHubActionsTestLogger/releases) - [Changelog](https://github.com/Tyrrrz/GitHubActionsTestLogger/blob/master/Changelog.md) - [Commits](Tyrrrz/GitHubActionsTestLogger@1.4.1...2.0.1) --- updated-dependencies: - dependency-name: GitHubActionsTestLogger dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.1.0 to 17.2.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v17.1.0...v17.2.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [MSTest.TestFramework](https://github.com/microsoft/testfx) from 2.2.8 to 2.2.10. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.2.8...v2.2.10) --- updated-dependencies: - dependency-name: MSTest.TestFramework dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 2.2.8 to 2.2.10. - [Release notes](https://github.com/microsoft/testfx/releases) - [Commits](microsoft/testfx@v2.2.8...v2.2.10) --- updated-dependencies: - dependency-name: MSTest.TestAdapter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rainer Sigwald <raines@microsoft.com>
baronfel
reviewed
Jul 13, 2022
System.Containers/Layer.cs
Outdated
| string tempTarballPath = Path.Join(tempPath, Path.GetRandomFileName()); | ||
| using (FileStream fs = File.Create(tempTarballPath)) | ||
| { | ||
| // using (GZipStream gz = new(fs, CompressionMode.Compress)) // TODO: https://github.com/dotnet/runtime/issues/65951#issuecomment-1145209082 |
There was a problem hiding this comment.
did this make it into preview 6? preemptive 🎆 in case it did
There was a problem hiding this comment.
Looks like yes per the tags on dotnet/runtime@1d6f23a
However, I'm not going to do it now because it will break a thing in my e2e branch--there's a place where we're supposed to hash the uncompressed tarball and some places where we're supposed to hash the compressed one, and right now they're conflated. Filed #29.
Closed
benvillalobos
approved these changes
Jul 13, 2022
With a tar API change that we should consume sooner rather than later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Descriptor with fields per the spec.
Some configuration and test infrastructure to help with e2e tests.
Implement
Layer.FromDirectoryto capture + tar a directory, analogous to a DockerfileCOPYinstruction.