update delegate and events samples #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For dotnet/docs#87 There were two major changes to update these samples. 1. UPgrade from project.json to csproj files. 1. Add snippet tags for including into the main topics.
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
May 25, 2018
Fixes #887 Relies on dotnet/samples#80 Provide links to downloadable samples, and update incline samples to use include snippets from the sample.
rpetrusha
approved these changes
May 25, 2018
There was a problem hiding this comment.
LGTM. I left one nit unrelated to your PR, @BillWagner, but you can merge when you're ready.
| } | ||
| catch (Exception) | ||
| { | ||
| // Hmm. We caught an exception while |
There was a problem hiding this comment.
nit: since comments aren't localized, this might be better if it were in the example explanation rather than an inline comment.
There was a problem hiding this comment.
There is explanatory text in the article as well. I'll leave the comment for those that just download the code.
BillWagner
added a commit
to dotnet/docs
that referenced
this pull request
Jun 6, 2018
* use code includes over inline copies Fixes #887 Relies on dotnet/samples#80 Provide links to downloadable samples, and update incline samples to use include snippets from the sample. * fix build errors A couple tags were mis-typed * respond to feedback Reviews from @JRAlexander and @repetrusha * fix one last typo
karelz
pushed a commit
to karelz/samples
that referenced
this pull request
Aug 31, 2018
For dotnet/docs#87 There were two major changes to update these samples. 1. UPgrade from project.json to csproj files. 1. Add snippet tags for including into the main topics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dotnet/docs#87
There were two major changes to update these samples.