Update samples for Csharp73 new generic constraints #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes them from the sub-directories in the docs repository.
pkulikov
reviewed
Apr 19, 2018
| // <Snippet6> | ||
| public interface IMyInterface | ||
| { | ||
| } |
There was a problem hiding this comment.
nit: for the sake of the screen space, I would put all the declaration in one line.
| // <Snippet9> | ||
| public class Employee | ||
| { | ||
| public Employee(string s, int i) => (Name, ID) = (s, i); |
There was a problem hiding this comment.
It's one of my favorite C# 7 tricks.
simplify an empty declaration.
rpetrusha
approved these changes
Apr 24, 2018
karelz
pushed a commit
to karelz/samples
that referenced
this pull request
Aug 31, 2018
* import existing snippets This removes them from the sub-directories in the docs repository. * finish generics samples. * respond to feedback. simplify an empty declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes:
unmanaged,System.DelegateandSystem.Enum.These samples will be part of the work to address dotnet/docs#3964
/cc @OmarTawfik @jcouv