-
Notifications
You must be signed in to change notification settings - Fork 216
[SwiftBindings] Setup xunit testing framework #2871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kotlarmilos
merged 20 commits into
feature/swift-bindings
from
swift-bindings/testing-framework
Dec 17, 2024
Merged
[SwiftBindings] Setup xunit testing framework #2871
kotlarmilos
merged 20 commits into
feature/swift-bindings
from
swift-bindings/testing-framework
Dec 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephen-hawley
suggested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see this branch get migrated to use TypeMetadata instead of void * and be ready to use the upcoming metadata access method in TypeMetadata. Like what I'm seeing.
src/Swift.Bindings/tests/IntegrationTests/CryptoKit/CryptoKit.cs
Outdated
Show resolved
Hide resolved
src/Swift.Bindings/tests/IntegrationTests/CryptoKit/CryptoKit.cs
Outdated
Show resolved
Hide resolved
rolfbjarne
approved these changes
Dec 12, 2024
src/Swift.Bindings/tests/IntegrationTests/Swift.Bindings.Integration.Tests.csproj
Outdated
Show resolved
Hide resolved
…dd smoke tests directory.
…to the output directory
jkurdek
reviewed
Dec 12, 2024
src/Swift.Bindings/tests/IntegrationTests/SmokeTests/SmokeTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 13, 2024
stephen-hawley
approved these changes
Dec 16, 2024
jkurdek
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the following test improvements:
This change improves debugging by referencing generated bindings within the integration tests. Additionally, it removes need for reflection in tests. On non-macOS platforms, only the tooling is built, and tests are skipped.
The objective is to set up the pipeline for StoreKit2 and SwiftUI, and begin tracking bindings coverage using the projection tooling, which will be introduced in a follow-up PR.