Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT-LLVM] Update llvm to 18.1.3 and emscripten to 3.1.54 #2595

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

yowl
Copy link
Contributor

@yowl yowl commented May 26, 2024

Updates the version of LLVM and emscripten.

depends #2591

Moving emscripten later than 3.1.54 causes C/C++ version standard problems, i.e. need to go from gnu99 to c11:

E.g.

C:/github/runtimelab/src/native/libs/System.Native/pal_networking.c(171,1): error GB0A439F3: '_Static_assert' is incompatible with C standards before C11 [-Wer
ror,-Wpre-c11-compat] [C:\github\runtimelab\src\native\libs\build-native.proj]

@yowl yowl changed the title [NativeAOT-LLVM] Update llvm to 18.1.3 and es [NativeAOT-LLVM] Update llvm to 18.1.3 and emscripten to 3.1.60 May 26, 2024
@yowl yowl changed the title [NativeAOT-LLVM] Update llvm to 18.1.3 and emscripten to 3.1.60 [NativeAOT-LLVM] Update llvm to 18.1.3 and emscripten to 3.1.55 May 27, 2024
@yowl
Copy link
Contributor Author

yowl commented May 27, 2024

Will squash once the May merge is in.

@yowl yowl changed the title [NativeAOT-LLVM] Update llvm to 18.1.3 and emscripten to 3.1.55 [NativeAOT-LLVM] Update llvm to 18.1.3 and emscripten to 3.1.54 May 27, 2024
@yowl
Copy link
Contributor Author

yowl commented May 31, 2024

cc @dotnet/nativeaot-llvm

@yowl yowl marked this pull request as ready for review May 31, 2024 10:41
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 838fd44 into dotnet:feature/NativeAOT-LLVM Jun 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants