Skip to content

[NativeAOT-LLVM] Upgrade emscripten and workaround cache lock problem #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 6, 2021

Conversation

yowl
Copy link
Contributor

@yowl yowl commented Nov 5, 2021

This PR upgrades the Emscripten version and puts a workaround for the cache lock problem we've been experiencing. I've not got to the bottom of the underlying reason, but the workaround seems ok locally (and it was failing locally before).

Workaround is to build the Emscripten ports for ICU and zlib upfront. These builds are cached, so it does not incur extra build work.

emscripten-core/emscripten#15440

Also suppress warning for __x variables as latest clang defines them as reserved identifiers.

yowl added 4 commits November 5, 2021 08:35
suppress warning for __x variables
workaround for emscripten cache lock
@SingleAccretion
Copy link

I think we need to add TODOs to remove the supressions once dotnet/runtime@2265a61 is merged (which also suppresses the warnings, but is present in the upstream).

@yowl
Copy link
Contributor Author

yowl commented Nov 6, 2021

Linux thread test failed with

native/BasicThreading ''
FinalizeTest failed
Expected: 100
Actual: 255

Seems unrelated.

@yowl yowl closed this Nov 6, 2021
@yowl yowl reopened this Nov 6, 2021
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 9d54885 into dotnet:feature/NativeAOT-LLVM Nov 6, 2021
@yowl yowl deleted the em2033 branch November 6, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants