Fix shared library build and add test #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`/wholearchive:` is the voodoo necessary for linker to include object files from a library that are otherwise not referenced. We need to include the bootstrapper because it has an initializer to initialize runtime that we depend on. I'm keeping the other workaround (`IlcProcessEntrypoint`) in place because we need it due to the `main`/`WinMain` schism for `OutputType=Exe/WinExe`.
MichalStrehovsky
added
the
area-NativeAOT-coreclr
Member
|
Would it be better to add unresolved reference to runtime library (e.g. a dummy call in the runtime initialization) and satisfy it in the bootstrapper? It would make it work like it used to work before by accident. |
Member
Author
I'm indifferent about those options - turns out the |
jkotas
reviewed
Sep 18, 2020
src/coreclr/src/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Windows.props
Outdated
Show resolved
Hide resolved
…ative.Windows.props
Member
Ok, let's give the wholearchive approach a try. |
jkotas
approved these changes
Sep 18, 2020
scalablecory
pushed a commit
that referenced
this pull request
Sep 22, 2020
jkotas
added a commit
to jkotas/runtimelab
that referenced
this pull request
Oct 26, 2020
Member
Author
|
Superseded by #270. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/wholearchive:is the voodoo necessary for linker to include object files from a library that are otherwise not referenced. We need to include the bootstrapper because it has an initializer to initialize runtime that we depend on.I'm keeping the other workaround (
IlcProcessEntrypoint) in place because we need it due to themain/WinMainschism forOutputType=Exe/WinExe.The test is from the CoreRT repo.