Throw when LCID marshalling is needed

[MichalStrehovsky]

We might want to at least fix the bad failure mode.

Interop/PInvoke/Attributes/LCID/LCIDTest

[MichalStrehovsky]

LCID marshalling is rare enough and Windows only that we should probably just have a good failure mode for this (instead of calling the method with the wrong calling convention, like we do right now).

We should probably just copy these two lines from crossgen2:

runtimelab/src/coreclr/src/tools/aot/ILCompiler.ReadyToRun/IL/Stubs/PInvokeILEmitter.cs

Lines 84 to 85 in 6072e4d

	if (_targetMethod.HasCustomAttribute("System.Runtime.InteropServices", "LCIDConversionAttribute"))
	throw new NotSupportedException();

And place them around here:

runtimelab/src/coreclr/src/tools/Common/TypeSystem/IL/Stubs/PInvokeILEmitter.cs

Lines 229 to 230 in beef8b0

	if (!_importMetadata.Flags.PreserveSig)
	throw new NotSupportedException();

Then add a test in the p/invoke smoke test that ensures methods that need LCID marshalling throw an exception when invoked (add a p/invoke declaration with LCID in it, and add a method with a try/catch block that calls the p/invoke).

[rohithv1997]

Hi @MichalStrehovsky ,
I would like to take this up.
Thanks!

[MichalStrehovsky]

You got it. Thank you!

[MichalStrehovsky]

Fixed in dotnet/runtime#63320.