Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove invalid Unsafe.As from array helpers #99778
Remove invalid Unsafe.As from array helpers #99778
Changes from 14 commits
198de58
9d72f6c
e4b716e
097207a
41608a5
55aaf7d
ea23fe4
463678a
0f6104c
8b98907
e59ad83
ebf890a
0d69258
1bdb1f6
e4a3096
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just use
ThrowHelper.ThrowIndexOutOfRangeException
given that is forINPLACE_RUNTIME
. It is unnecessary to go throughGetClasslibException
indirection forINPLACE_RUNTIME
. The main point ofINPLACE_RUNTIME
is to avoid these indirections.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to remove the
!INPLACE_RUNTIME
code in the next PR and to keep this like earlier for now.Also I think that
ThrowHelper
is not in theTest.CoreLib
(not sure what that is for tbh but right now there's a build failure here due toMemoryMarshal
not being there too).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test.CoreLib is very minimal implementation of CoreLib for testing, debugging and various experiments. It is fine to add minimal implementations of MemoryMarshal or ThrowHelper to it to keep it working.