Skip to content

UInt128 improve division by 64 bit on x64 #99747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 30, 2024
+15 −0
Merged

UInt128 improve division by 64 bit on x64 #99747

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c88a477
Add fast path for UInt128 division on x64 when divisor is as most 64bits
Daniel-Svensson Mar 11, 2024
a5dd98e
Update src/libraries/System.Private.CoreLib/src/System/UInt128.cs
Daniel-Svensson Mar 14, 2024
60cc066
Supress warning CA2252 // This API requires opting into preview features
Daniel-Svensson Jun 7, 2024
19b92d9
Check upper bits for 0 and do normal divion for x64 (faster when it i…
Daniel-Svensson Jun 11, 2024
6980103
Merge branch 'main' into fast_x64_uint128_div
tannergooding Jul 10, 2024
740c48d
Merge remote-tracking branch 'upstream/main' into fast_x64_uint128_div
Daniel-Svensson Sep 12, 2024
6d185b3
Change supression to SYSLIB5004 after DivRem was changes to [Experime…
Daniel-Svensson Sep 12, 2024
0c81985
Merge remote-tracking branch 'origin/fast_x64_uint128_div' into fast_…
Daniel-Svensson Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check upper bits for 0 and do normal divion for x64 (faster when it i… 
…s known that upper is zero such as division by constant)
  • Loading branch information
@Daniel-Svensson
Daniel-Svensson committed Jun 11, 2024
commit 19b92d90876a5cc014e8149b2dbf8356623659ba
12 changes: 6 additions & 6 deletions src/libraries/System.Private.CoreLib/src/System/UInt128.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,12 @@ public static UInt128 Log2(UInt128 value)
ThrowHelper.ThrowDivideByZeroException();
}

if (X86Base.X64.IsSupported)
if (left._upper == 0)
{
// left and right are both uint64
return left._lower / right._lower;
}
else if (X86Base.X64.IsSupported)
{
ulong highRes = 0ul;
ulong remainder = left._upper;
Expand All @@ -1113,11 +1118,6 @@ public static UInt128 Log2(UInt128 value)
return new UInt128(highRes, X86Base.X64.DivRem(left._lower, remainder, right._lower).Quotient);
#pragma warning restore CA2252 // This API requires opting into preview features
}
else if (left._upper == 0)
{
// left and right are both uint64
return left._lower / right._lower;
}
}

if (right >= left)
Expand Down