Optimize memory allocations (#98702) #99542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
cd21h
force-pushed
the
feature/98702-Memory-optimization
branch
from
14b9674 to
7b0968f
Compare
src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs
Outdated
Show resolved
Hide resolved
…m/shatl/dotnet-runtime into feature/98702-Memory-optimization
|
@MichalPetryka Could you take a look, please? |
tarekgh
reviewed
May 13, 2024
src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs
Outdated
Show resolved
Hide resolved
|
@cd21h could you please resolve the source conflict to be able to proceed? Also, for my comment #99542 (review) feel free to address it or if you want can address it in another PR. Thanks! |
tarekgh
added
the
needs-author-action
tarekgh
force-pushed
the
feature/98702-Memory-optimization
branch
from
a1acfd4 to
6329581
Compare
dotnet-policy-service
bot
removed
the
needs-author-action
|
@cd21h I have pushed a commit for optimizing the other case in addition to merging main to your branch. Please have a look and let me know if it makes sense to you. Also, could you please accept the license agreement too #99542 (comment)? Thanks! |
…m/shatl/dotnet-runtime into feature/98702-Memory-optimization # Conflicts: # src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs
@dotnet-policy-service agree |
|
@tarekgh Looks good to me! |
MihaZupan
reviewed
May 14, 2024
src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
May 14, 2024
src/libraries/Microsoft.Extensions.Logging.Console/src/JsonConsoleFormatter.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
May 14, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* Optimize memory allocations (dotnet#98702) * Use `UTF8.GetMaxCharCount` * Optimize memory allocations (dotnet#98702) * Use `UTF8.GetMaxCharCount` * Optimize netfx/netstandard 2.0 cases too * Fix formatting * Fix build error --------- Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ArrayPoolto reduce memory allocations when writing JSON