Skip to content

Cleanup ifdefs #99511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,12 @@
<Compile Include="$(BclSourcesRoot)\System\Runtime\CompilerServices\RuntimeHelpers.CoreCLR.cs" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\ControlledExecution.CoreCLR.cs" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\DependentHandle.cs" />
<Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Common\src\System\Runtime\RhFailFastReason.cs" Condition="('$(Platform)' != 'x86' or '$(TargetsWindows)' != 'true')" />
<Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Runtime.Base\src\System\Runtime\ExceptionHandling.cs" Condition="('$(Platform)' != 'x86' or '$(TargetsWindows)' != 'true')" />
<Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Runtime.Base\src\System\Runtime\ExceptionIDs.cs" Condition="('$(Platform)' != 'x86' or '$(TargetsWindows)' != 'true')" />
<Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Runtime.Base\src\System\Runtime\StackFrameIterator.cs" Condition="('$(Platform)' != 'x86' or '$(TargetsWindows)' != 'true')" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\ExceptionServices\AsmOffsets.cs" Condition="('$(Platform)' != 'x86' or '$(TargetsWindows)' != 'true')" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\ExceptionServices\InternalCalls.cs" Condition="('$(Platform)' != 'x86' or '$(TargetsWindows)' != 'true')" />
<Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Common\src\System\Runtime\RhFailFastReason.cs" />
<Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Runtime.Base\src\System\Runtime\ExceptionHandling.cs" />
<Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Runtime.Base\src\System\Runtime\ExceptionIDs.cs" />
<Compile Include="$(MSBuildThisFileDirectory)..\nativeaot\Runtime.Base\src\System\Runtime\StackFrameIterator.cs" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\ExceptionServices\AsmOffsets.cs" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\ExceptionServices\InternalCalls.cs" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\GCSettings.CoreCLR.cs" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\JitInfo.CoreCLR.cs" />
<Compile Include="$(BclSourcesRoot)\System\Runtime\InteropServices\ComTypes\IEnumerable.cs" />
Expand Down
18 changes: 0 additions & 18 deletions src/coreclr/clr.featuredefines.props
Original file line number Diff line number Diff line change
@@ -1,37 +1,26 @@
<Project>
<PropertyGroup>
<FeatureCoreCLR>true</FeatureCoreCLR>
<FeatureCollectibleALC>true</FeatureCollectibleALC>
<FeatureEventTrace>true</FeatureEventTrace>
<FeatureICastable>true</FeatureICastable>
<FeaturePerfTracing>true</FeaturePerfTracing>
<FeatureTypeEquivalence>true</FeatureTypeEquivalence>
<FeatureBasicFreeze>true</FeatureBasicFreeze>
<ProfilingSupportedBuild>true</ProfilingSupportedBuild>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetsUnix)' == 'true'">
<FeatureXplatEventSource Condition="'$(TargetOS)' == 'linux'">true</FeatureXplatEventSource>

<FeatureArrayStubAsIL>true</FeatureArrayStubAsIL>
<FeatureMulticastStubAsIL>true</FeatureMulticastStubAsIL>
<FeaturePortableShuffleThunks Condition="'$(Platform)' != 'x86'">true</FeaturePortableShuffleThunks>
<FeatureInstantiatingStubAsIL>true</FeatureInstantiatingStubAsIL>
<FeatureStubsAsIL>true</FeatureStubsAsIL>
<FeatureComWrappers>true</FeatureComWrappers>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetsWindows)' == 'true'">
<FeatureArrayStubAsIL Condition="'$(Platform)' != 'x86'">true</FeatureArrayStubAsIL>
<FeatureMulticastStubAsIL Condition="'$(Platform)' != 'x86'">true</FeatureMulticastStubAsIL>
<FeatureStubsAsIL Condition="'$(Platform)' == 'arm64'">true</FeatureStubsAsIL>
<FeatureComWrappers>true</FeatureComWrappers>
<FeatureCominterop>true</FeatureCominterop>
<FeatureCominteropApartmentSupport>true</FeatureCominteropApartmentSupport>
<FeatureWin32Registry>true</FeatureWin32Registry>
<FeatureProfAttach>true</FeatureProfAttach>
<FeaturePortableShuffleThunks Condition="'$(Platform)' != 'x86'">true</FeaturePortableShuffleThunks>
<FeatureInstantiatingStubAsIL Condition="'$(Platform)' != 'x86'">true</FeatureInstantiatingStubAsIL>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetsOSX)' == 'true' OR '$(TargetsMacCatalyst)' == 'true' OR '$(TargetsiOS)' == 'true' OR '$(TargetstvOS)' == 'true'">
Expand All @@ -45,23 +34,16 @@
<PropertyGroup>
<DefineConstants Condition="'$(FeatureArrayStubAsIL)' == 'true'">$(DefineConstants);FEATURE_ARRAYSTUB_AS_IL</DefineConstants>
<DefineConstants Condition="'$(FeatureMulticastStubAsIL)' == 'true'">$(DefineConstants);FEATURE_MULTICASTSTUB_AS_IL</DefineConstants>
<DefineConstants Condition="'$(FeatureInstantiatingStubAsIL)' == 'true'">$(DefineConstants);FEATURE_INSTANTIATINGSTUB_AS_IL</DefineConstants>
<DefineConstants Condition="'$(FeatureStubsAsIL)' == 'true'">$(DefineConstants);FEATURE_STUBS_AS_IL</DefineConstants>
<DefineConstants Condition="'$(FeatureCollectibleALC)' == 'true'">$(DefineConstants);FEATURE_COLLECTIBLE_ALC</DefineConstants>
<DefineConstants Condition="'$(FeatureComWrappers)' == 'true'">$(DefineConstants);FEATURE_COMWRAPPERS</DefineConstants>
<DefineConstants Condition="'$(FeatureCominterop)' == 'true'">$(DefineConstants);FEATURE_COMINTEROP</DefineConstants>
<DefineConstants Condition="'$(FeatureCominteropApartmentSupport)' == 'true'">$(DefineConstants);FEATURE_COMINTEROP_APARTMENT_SUPPORT</DefineConstants>
<DefineConstants Condition="'$(FeatureObjCMarshal)' == 'true'">$(DefineConstants);FEATURE_OBJCMARSHAL</DefineConstants>
<DefineConstants Condition="'$(FeaturePerfTracing)' == 'true'">$(DefineConstants);FEATURE_PERFTRACING</DefineConstants>
<DefineConstants Condition="'$(FeatureXplatEventSource)' == 'true'">$(DefineConstants);FEATURE_EVENTSOURCE_XPLAT</DefineConstants>
<DefineConstants Condition="'$(FeatureWin32Registry)' == 'true'">$(DefineConstants);FEATURE_WIN32_REGISTRY</DefineConstants>
<DefineConstants Condition="'$(FeatureTypeEquivalence)' == 'true'">$(DefineConstants);FEATURE_TYPEEQUIVALENCE</DefineConstants>
<DefineConstants Condition="'$(FeatureBasicFreeze)' == 'true'">$(DefineConstants);FEATURE_BASICFREEZE</DefineConstants>
<DefineConstants Condition="'$(FeaturePortableShuffleThunks)' == 'true'">$(DefineConstants);FEATURE_PORTABLE_SHUFFLE_THUNKS</DefineConstants>
<DefineConstants Condition="'$(FeatureICastable)' == 'true'">$(DefineConstants);FEATURE_ICASTABLE</DefineConstants>
<DefineConstants Condition="'$(FeatureEHFunclets)' == 'true'">$(DefineConstants);FEATURE_EH_FUNCLETS</DefineConstants>

<DefineConstants Condition="'$(ProfilingSupportedBuild)' == 'true'">$(DefineConstants);PROFILING_SUPPORTED</DefineConstants>
<DefineConstants Condition="'$(FeatureProfAttach)' == 'true'">$(DefineConstants);FEATURE_PROFAPI_ATTACH_DETACH</DefineConstants>
</PropertyGroup>
</Project>
3 changes: 0 additions & 3 deletions src/coreclr/clrdefinitions.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,6 @@ if(CLR_CMAKE_TARGET_ARCH_AMD64 OR CLR_CMAKE_TARGET_ARCH_ARM64 OR CLR_CMAKE_TARGE
add_definitions(-DFEATURE_MANUALLY_MANAGED_CARD_BUNDLES)
endif(CLR_CMAKE_TARGET_ARCH_AMD64 OR CLR_CMAKE_TARGET_ARCH_ARM64 OR CLR_CMAKE_TARGET_ARCH_LOONGARCH64 OR CLR_CMAKE_TARGET_ARCH_RISCV64)

if(NOT CLR_CMAKE_TARGET_UNIX)
add_definitions(-DFEATURE_WIN32_REGISTRY)
endif(NOT CLR_CMAKE_TARGET_UNIX)
add_definitions(-D_SECURE_SCL=0)
add_definitions(-DUNICODE)
add_definitions(-D_UNICODE)
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/debug/ee/debugger.h
Original file line number Diff line number Diff line change
Expand Up @@ -3892,8 +3892,6 @@ HANDLE OpenWin32EventOrThrow(
// Returns true if the specified IL offset has a special meaning (eg. prolog, etc.)
bool DbgIsSpecialILOffset(DWORD offset);

#if !defined(TARGET_X86)
void FixupDispatcherContext(T_DISPATCHER_CONTEXT* pDispatcherContext, T_CONTEXT* pContext, PEXCEPTION_ROUTINE pUnwindPersonalityRoutine = NULL);
#endif

#endif /* DEBUGGER_H_ */
3 changes: 0 additions & 3 deletions src/coreclr/inc/clrnt.h
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,7 @@ RtlpGetFunctionEndAddress (
#define RUNTIME_FUNCTION__SetUnwindInfoAddress(prf, addr) do { (prf)->UnwindData = (addr); } while(0)

#ifdef HOST_X86
EXTERN_C
NTSYSAPI
PEXCEPTION_ROUTINE
NTAPI
RtlVirtualUnwind (
_In_ DWORD HandlerType,
_In_ DWORD ImageBase,
Expand Down
3 changes: 1 addition & 2 deletions src/coreclr/inc/daccess.h
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,6 @@ struct COR_ILMETHOD* DacGetIlMethod(TADDR methAddr);
struct _UNWIND_INFO * DacGetUnwindInfo(TADDR taUnwindInfo);

// virtually unwind a CONTEXT out-of-process
struct _KNONVOLATILE_CONTEXT_POINTERS;
BOOL DacUnwindStackFrame(T_CONTEXT * pContext, T_KNONVOLATILE_CONTEXT_POINTERS* pContextPointers);
#endif // FEATURE_EH_FUNCLETS

Expand Down Expand Up @@ -2433,7 +2432,7 @@ typedef DPTR(IMAGE_TLS_DIRECTORY) PTR_IMAGE_TLS_DIRECTORY;
#endif

#ifndef NATIVEAOT
#if defined(TARGET_X86) && defined(TARGET_UNIX)
#if defined(TARGET_X86) && defined(FEATURE_EH_FUNCLETS)
typedef DPTR(struct _UNWIND_INFO) PTR_UNWIND_INFO;
#endif

Expand Down
5 changes: 1 addition & 4 deletions src/coreclr/unwinder/i386/unwinder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ BOOL OOPStackUnwinderX86::Unwind(T_CONTEXT* pContextRecord, T_KNONVOLATILE_CONTE
dac_cast<PTR_CBYTE>(gcInfoToken.Info) + hdrInfoSize,
PTR_CBYTE(codeInfo.GetJitManager()->GetFuncletStartAddress(&codeInfo)),
codeInfo.IsFunclet(),
UpdateAllRegs))
true))
{
return FALSE;
}
Expand Down Expand Up @@ -193,10 +193,7 @@ BOOL DacUnwindStackFrame(T_CONTEXT* pContextRecord, T_KNONVOLATILE_CONTEXT_POINT
// language specific exception handler is returned. Otherwise, NULL is
// returned.
//
EXTERN_C
NTSYSAPI
PEXCEPTION_ROUTINE
NTAPI
RtlVirtualUnwind (
_In_ DWORD HandlerType,
_In_ DWORD ImageBase,
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/vm/.vscode/c_cpp_properties.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
"FEATURE_USE_ASM_GC_WRITE_BARRIERS",
"FEATURE_USE_SOFTWARE_WRITE_WATCH_FOR_GC_HEAP",
"FEATURE_UTF8STRING=1",
"FEATURE_WIN32_REGISTRY",
"TARGET_WINDOWS=1",
"PROFILING_SUPPORTED_DATA",
"UNICODE",
Expand Down
13 changes: 6 additions & 7 deletions src/coreclr/vm/codeman.h
Original file line number Diff line number Diff line change
Expand Up @@ -2619,21 +2619,20 @@ class EECodeInfo
PTR_RUNTIME_FUNCTION GetFunctionEntry();
BOOL IsFunclet() { WRAPPER_NO_CONTRACT; return GetJitManager()->IsFunclet(this); }
EECodeInfo GetMainFunctionInfo();
ULONG GetFixedStackSize();

#if defined(TARGET_AMD64)
BOOL HasFrameRegister();
#endif // TARGET_AMD64
#endif // FEATURE_EH_FUNCLETS

#else // FEATURE_EH_FUNCLETS
#if defined(TARGET_X86)
ULONG GetFixedStackSize()
{
WRAPPER_NO_CONTRACT;
return GetCodeManager()->GetFrameSize(GetGCInfoToken());
}
#endif // FEATURE_EH_FUNCLETS
#endif // TARGET_X86

#if defined(TARGET_AMD64)
BOOL HasFrameRegister();
ULONG GetFixedStackSize();

void GetOffsetsFromUnwindInfo(ULONG* pRSPOffset, ULONG* pRBPOffset);
ULONG GetFrameOffsetFromUnwindInfo();
#if defined(_DEBUG) && defined(HAVE_GCCOVER)
Expand Down
3 changes: 1 addition & 2 deletions src/coreclr/vm/eetwain.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1650,7 +1650,6 @@ OBJECTREF EECodeManager::GetInstance( PREGDISPLAY pContext,
hdrInfo info;
unsigned stackDepth;
TADDR taArgBase;
unsigned count;

/* Extract the necessary information from the info block header */

Expand Down Expand Up @@ -1709,7 +1708,7 @@ OBJECTREF EECodeManager::GetInstance( PREGDISPLAY pContext,
/* The 'this' pointer can never be located in the untracked table */
/* as we only allow pinned and byrefs in the untracked table */

count = info.untrackedCnt;
unsigned count = info.untrackedCnt;
while (count-- > 0)
{
fastSkipSigned(table);
Expand Down
17 changes: 5 additions & 12 deletions src/coreclr/vm/excep.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8894,11 +8894,9 @@ BOOL IsThrowableThreadAbortException(OBJECTREF oThrowable)
#if defined(FEATURE_EH_FUNCLETS)
PTR_ExceptionTrackerBase GetEHTrackerForPreallocatedException(OBJECTREF oPreAllocThrowable,
PTR_ExceptionTrackerBase pStartingEHTracker)
#elif TARGET_X86
#else
PTR_ExInfo GetEHTrackerForPreallocatedException(OBJECTREF oPreAllocThrowable,
PTR_ExInfo pStartingEHTracker)
#else
#error Unsupported platform
#endif
{
CONTRACTL
Expand All @@ -8916,11 +8914,9 @@ PTR_ExInfo GetEHTrackerForPreallocatedException(OBJECTREF oPreAllocThrowable,
// Get the reference to the current exception tracker
#if defined(FEATURE_EH_FUNCLETS)
PTR_ExceptionTrackerBase pEHTracker = (pStartingEHTracker != NULL) ? pStartingEHTracker : GetThread()->GetExceptionState()->GetCurrentExceptionTracker();
#elif TARGET_X86
#else
PTR_ExInfo pEHTracker = (pStartingEHTracker != NULL) ? pStartingEHTracker : GetThread()->GetExceptionState()->GetCurrentExceptionTracker();
#else // !(HOST_64BIT || TARGET_X86)
#error Unsupported platform
#endif // HOST_64BIT
#endif

BOOL fFoundTracker = FALSE;

Expand Down Expand Up @@ -8995,13 +8991,10 @@ PTR_EHWatsonBucketTracker GetWatsonBucketTrackerForPreallocatedException(OBJECTR
#if defined(FEATURE_EH_FUNCLETS)
PTR_ExceptionTrackerBase pEHTracker = NULL;
PTR_ExceptionTrackerBase pPreviousEHTracker = NULL;

#elif TARGET_X86
#else
PTR_ExInfo pEHTracker = NULL;
PTR_ExInfo pPreviousEHTracker = NULL;
#else // !(HOST_64BIT || TARGET_X86)
#error Unsupported platform
#endif // HOST_64BIT
#endif

if (fStartSearchFromPreviousTracker)
{
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/vm/excep.h
Original file line number Diff line number Diff line change
Expand Up @@ -520,9 +520,9 @@ EXCEPTION_HANDLER_DECL(COMPlusFrameHandlerRevCom);
// Pop off any SEH handlers we have registered below pTargetSP
VOID __cdecl PopSEHRecords(LPVOID pTargetSP);

#if defined(TARGET_X86) && defined(DEBUGGING_SUPPORTED)
#ifdef DEBUGGING_SUPPORTED
VOID UnwindExceptionTrackerAndResumeInInterceptionFrame(ExInfo* pExInfo, EHContext* context);
#endif // TARGET_X86 && DEBUGGING_SUPPORTED
#endif // DEBUGGING_SUPPORTED

BOOL PopNestedExceptionRecords(LPVOID pTargetSP, BOOL bCheckForUnknownHandlers = FALSE);
VOID PopNestedExceptionRecords(LPVOID pTargetSP, T_CONTEXT *pCtx, void *pSEH);
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/vm/exinfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ void ExInfo::Init()

m_pTopMostHandlerDuringSO = NULL;

#if defined(TARGET_X86) && defined(DEBUGGING_SUPPORTED)
#ifdef DEBUGGING_SUPPORTED
m_InterceptionContext.Init();
m_ValidInterceptionContext = FALSE;
#endif //TARGET_X86 && DEBUGGING_SUPPORTED
#endif // DEBUGGING_SUPPORTED
}

ExInfo::ExInfo()
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/vm/exinfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ class ExInfo
EHClauseInfo m_EHClauseInfo;
ExceptionFlags m_ExceptionFlags;

#if defined(TARGET_X86) && defined(DEBUGGING_SUPPORTED)
#ifdef DEBUGGING_SUPPORTED
EHContext m_InterceptionContext;
BOOL m_ValidInterceptionContext;
#endif
Expand All @@ -155,9 +155,7 @@ class ExInfo
ExInfo& operator=(const ExInfo &from);
};

#if defined(TARGET_X86)
PTR_ExInfo GetEHTrackerForPreallocatedException(OBJECTREF oPreAllocThrowable, PTR_ExInfo pStartingEHTracker);
#endif // TARGET_X86

#else // !FEATURE_EH_FUNCLETS

Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/vm/i386/asmconstants.h
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,6 @@ ASMCONSTANTS_C_ASSERT(OFFSETOF__FrameHandlerExRecord__m_pEntryFrame == offsetof(
#define STACK_OVERWRITE_BARRIER_VALUE 0xabcdefab
#endif

#define SIZEOF_FrameHandlerExRecordWithBarrier 0x5c
ASMCONSTANTS_C_ASSERT(SIZEOF_FrameHandlerExRecordWithBarrier == sizeof(FrameHandlerExRecordWithBarrier))
#endif


Expand Down
4 changes: 4 additions & 0 deletions src/coreclr/vm/i386/jithelp.asm
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ EXTERN g_GCShadowEnd:DWORD
INVALIDGCVALUE equ 0CCCCCCCDh
endif

ifndef FEATURE_EH_FUNCLETS
EXTERN _COMPlusEndCatch@20:PROC
endif

.686P
.XMM
Expand Down Expand Up @@ -1298,6 +1300,7 @@ ret
_JIT_PatchedCodeEnd@0 endp


ifndef FEATURE_EH_FUNCLETS
; Note that the debugger skips this entirely when doing SetIP,
; since COMPlusCheckForAbort should always return 0. Excep.cpp:LeaveCatch
; asserts that to be true. If this ends up doing more work, then the
Expand Down Expand Up @@ -1325,6 +1328,7 @@ JIT_EndCatch PROC stdcall public
jmp edx ; eip = new eip

JIT_EndCatch ENDP
endif

; The following helper will access ("probe") a word on each page of the stack
; starting with the page right beneath esp down to the one pointed to by eax.
Expand Down
11 changes: 5 additions & 6 deletions src/coreclr/vm/rtlfunctions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
#include "rtlfunctions.h"


#ifdef TARGET_AMD64
#ifdef HOST_AMD64

RtlVirtualUnwindFn* RtlVirtualUnwind_Unsafe = NULL;

Expand Down Expand Up @@ -45,17 +45,17 @@ HRESULT EnsureRtlFunctions()
return S_OK;
}

#else // TARGET_AMD64
#else // HOST_AMD64

HRESULT EnsureRtlFunctions()
{
LIMITED_METHOD_CONTRACT;
return S_OK;
}

#endif // TARGET_AMD64
#endif // HOST_AMD64

#if defined(FEATURE_EH_FUNCLETS)
#ifndef HOST_X86

VOID InstallEEFunctionTable (
PVOID pvTableID,
Expand Down Expand Up @@ -127,5 +127,4 @@ VOID InstallEEFunctionTable (
}
}

#endif // FEATURE_EH_FUNCLETS

#endif // HOST_X86
6 changes: 3 additions & 3 deletions src/coreclr/vm/rtlfunctions.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ PVOID DecodeDynamicFunctionTableContext (PVOID pvContext)
#endif // FEATURE_EH_FUNCLETS


#if defined(FEATURE_EH_FUNCLETS) && !defined(DACCESS_COMPILE) && !defined(TARGET_UNIX)
#if !defined(DACCESS_COMPILE) && defined(HOST_WINDOWS) && !defined(HOST_X86)

// Wrapper for RtlInstallFunctionTableCallback.
VOID InstallEEFunctionTable(
Expand All @@ -67,12 +67,12 @@ VOID DeleteEEFunctionTable(
RtlDeleteFunctionTable((PT_RUNTIME_FUNCTION)((ULONG64)pvTableID | 3));
}

#else // FEATURE_EH_FUNCLETS && !DACCESS_COMPILE && !TARGET_UNIX
#else

#define InstallEEFunctionTable(pvTableID, pvStartRange, cbRange, pfnGetRuntimeFunctionCallback, pvContext, TableType) do { } while (0)
#define DeleteEEFunctionTable(pvTableID) do { } while (0)

#endif // FEATURE_EH_FUNCLETS && !DACCESS_COMPILE && !TARGET_UNIX
#endif


#endif // !__RTLFUNCTIONS_H__
2 changes: 0 additions & 2 deletions src/coreclr/vm/threads.h
Original file line number Diff line number Diff line change
Expand Up @@ -6222,9 +6222,7 @@ class StackWalkerWalkingThreadHolder
#if defined(TARGET_WINDOWS) && defined(TARGET_AMD64)
EXTERN_C void STDCALL ClrRestoreNonvolatileContextWorker(PCONTEXT ContextRecord, DWORD64 ssp);
#endif
#if !(defined(TARGET_WINDOWS) && defined(TARGET_X86))
void ClrRestoreNonvolatileContext(PCONTEXT ContextRecord);
#endif
#endif // DACCESS_COMPILE

#endif //__threads_h__