[browser][MT] dedicated io thread#99422
Merged
pavelsavara merged 9 commits intodotnet:mainfrom Mar 14, 2024
Merged
Conversation
This was referenced Mar 8, 2024
da607d0 to
738be39
Compare
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1e0c0b2 to
2bfe57a
Compare
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 10, 2024
System.Net.Http.Functional.Tests.HttpMetricsTest_Http11_Async_HttpMessageInvoker Test failure
#96407
Closed
4 tasks
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
we have deadlock in This is exactly the scenario that this PR should solve. It's synchronous Wait on |
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 13, 2024
7020bf6 to
3e80e32
Compare
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maraf
reviewed
Mar 14, 2024
Member
maraf
left a comment
There was a problem hiding this comment.
I'm missing change in dotnet.d.ts. Most of the comments are nits
...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs
Show resolved
Hide resolved
...vices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHostImplementation.Types.cs
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
...aScript/src/System/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs
Outdated
Show resolved
Hide resolved
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
…stem/Runtime/InteropServices/JavaScript/Marshaling/JSMarshalerArgument.Task.cs Co-authored-by: Marek Fišera <mara@neptuo.com>
Co-authored-by: Marek Fišera <mara@neptuo.com>
maraf
approved these changes
Mar 14, 2024
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.Waiton deputy thread in async methods, async JSExport, C#Main()changes
BeforeSyncJSExportandAfterSyncJSExportalso onJSWebWorker(same thread)ConfigureAwait(true)in HTTP clientmono_wasm_print_thread_dumptoINTERNALtests
WaitDoesNotAssertInAsyncCode<-- this is why we do this!WaitAssertsOnSyncCallbackWaitAssertsOnSyncJSExportSystem.Runtime.InteropServices.JavaScript.BackgroundExec.Testsnew active issues