Skip to content

Fix build break #99325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix build break #99325

merged 1 commit into from
Mar 5, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 5, 2024

Fixes #99320

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 5, 2024
@ghost ghost assigned jkotas Mar 5, 2024
@jkotas jkotas added area-System.Threading and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 5, 2024
@ghost
Copy link

ghost commented Mar 5, 2024

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #99320

Author: jkotas
Assignees: jkotas
Labels:

area-System.Threading, needs-area-label

Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Mar 5, 2024

Introduced by #98984

@stephentoub stephentoub merged commit ea36633 into dotnet:main Mar 5, 2024
@stephentoub
Copy link
Member

Merging to fix build break

@jkotas jkotas deleted the build-break branch March 5, 2024 19:03
@kg
Copy link
Member

kg commented Mar 5, 2024

Additional errors appeared after merging this, I'm guessing they can be fixed the same way? The analyzer doesn't feel fully baked, the docs link (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2265) is broken so I'm not sure what the context for this rule is and whether it's actually the case that comparing a span against default is never correct. The two cases I looked at (in JsonTestHelper.cs) seem like they're not a mistake.

jkotas added a commit that referenced this pull request Mar 5, 2024
@jkotas
Copy link
Member Author

jkotas commented Mar 5, 2024

Let's revert the analyzer update.

I'm not sure what the context for this rule is and whether it's actually the case that comparing a span against default is never correct.

Yes, analyzers can have false positives. It is true for analyzers in general.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System.Private.CoreLib] Compilation error: Comparing a span to 'null' might be redundant
3 participants