Delete stackwalk cache #99137
Merged
Delete stackwalk cache #99137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
jkotas
force-pushed
the
stackwalkcache
branch
2 times, most recently
from
10526fe to
bf8d29e
Compare
This was referenced Mar 1, 2024
janvorli
approved these changes
Mar 1, 2024
|
CI should catch this, but just in case: my recently merged #98908 added a new call to the To fix, replace with: GetThread()->StackWalkFrames(FindFailFastCallerCallback, &findCallerData, FUNCTIONSONLY | QUICKUNWIND); |
jkotas
commented
Mar 5, 2024
| @@ -2716,7 +2716,7 @@ class Thread | |||
| // stack crawl. Eventually need to always do this but it | |||
| // breaks the debugger right now. | |||
|
|
|||
| #define LIGHTUNWIND 0x0020 // allow using cache schema (see StackwalkCache class) | |||
There was a problem hiding this comment.
There is confusion about what's called LIGHTUNWIND vs. QUICKUNWIND. The implementation of the LIGHTUNWIND was under HAS_QUICKUNWIND ifdef and otherwise used Quick Unwind names.
The distinction between LIGHTUNWIND vs. QUICKUNWIND seems to be important for Windows x86 unwinding in abnormal situations, so I am going to keep it, but I am going to rename everything related to light unwind to be called light unwind.
jkotas
force-pushed
the
stackwalkcache
branch
4 times, most recently
from
7f3f965 to
12113ec
Compare
… bit on x86, but it is not worth it to keep it around for that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It costs about as much as it saves on x64. It may be helping a little bit on x86, but it is not worth it to keep it around for that.