Skip to content

Prevent incorrect constant folding #98561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Prevent incorrect constant folding #98561

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4cf46ae
Prevent incorrect constant folding of binary operations involving han…
filipnavara Feb 16, 2024
3ced9a9
Fix the conditions for null nodes
filipnavara Feb 16, 2024
3d51316
Fix the last commit for non-GT/GE/LT/LE
filipnavara Feb 16, 2024
aec020f
Make JIT format happy
filipnavara Feb 16, 2024
4d7744f
More conservative approach. Limit only arithmetic operations involvin…
filipnavara Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/coreclr/jit/valuenum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4421,6 +4421,11 @@ bool ValueNumStore::VNEvalCanFoldBinaryFunc(var_types type, VNFunc func, ValueNu
case GT_RSZ:
case GT_ROL:
case GT_ROR:
if (m_pComp->opts.compReloc && (IsVNHandle(arg0VN) || IsVNHandle(arg1VN)))
{
return false;
}
break;

case GT_EQ:
case GT_NE:
Expand Down Expand Up @@ -4449,6 +4454,11 @@ bool ValueNumStore::VNEvalCanFoldBinaryFunc(var_types type, VNFunc func, ValueNu
case VNF_ADD_UN_OVF:
case VNF_SUB_UN_OVF:
case VNF_MUL_UN_OVF:
if (m_pComp->opts.compReloc && (IsVNHandle(arg0VN) || IsVNHandle(arg1VN)))
{
return false;
}
break;

case VNF_Cast:
case VNF_CastOvf:
Expand Down