Skip to content

JIT: Always assign edge likelihoods in fgIncorporateProfileData #98054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 51 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
b8447d7
Always assign edge likelihoods
amanasifkhalid Feb 6, 2024
4777436
Add AssignLikelihoodsOnly to reduce diffs for now
amanasifkhalid Feb 6, 2024
85b5eab
Ensure that constant folding for SIMD shifts on xarch follow the corr…
tannergooding Feb 6, 2024
5d3a3c1
Move ManagedHost project for host tests to pre-built test asset (#97894)
elinor-fung Feb 6, 2024
f4fa259
Remove strtok, strtok_s, wcstok_s PAL APIs (#98008)
jkoritzinsky Feb 7, 2024
0cbbe7e
Deduplicate LSDA data in the object writer (#97972)
MichalStrehovsky Feb 7, 2024
47f325e
Delete useless delegate virtual methods (#97959)
MichalStrehovsky Feb 7, 2024
063447d
STJ: Skip usage of indexer for KeyedCollection (#97734)
manandre Feb 7, 2024
24d149c
Fix #98050. (#98058)
eiriktsarpalis Feb 7, 2024
97aba78
[browser][MT] withDumpThreadsOnNonZeroExit (#98052)
pavelsavara Feb 7, 2024
9dd8f52
[Mono] [Arm64] Add SIMD support for vector ctors (#98037)
jkurdek Feb 7, 2024
0b96be1
Unblock (#97977)
ilonatommy Feb 7, 2024
59831ac
[wasm][mt] Improve blocking wait detection and tests (#98045)
radekdoulik Feb 7, 2024
ff9a888
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Feb 7, 2024
765d884
BitCast<TYP_REF>(TypeHandleToRuntimeTypeHandle(clsHandle)) => nongc o…
EgorBo Feb 7, 2024
77fbbc4
[main] Update dependencies from dotnet/arcade (#98091)
dotnet-maestro[bot] Feb 7, 2024
569b86a
Add encoding for ARM64 IF_SVE_CJ_2A instruction group (#97885)
snickolls-arm Feb 7, 2024
19dbb6a
Remove StackFrameIterator.ShouldSkipRegularGcReporting (#98081)
filipnavara Feb 7, 2024
18655ee
[browser][mt] Fix `package microsoft.netcore.app.runtime.mono.multith…
ilonatommy Feb 7, 2024
bafd250
Take into account the local involved in GT_SWITCH for resolution (#97…
kunalspathak Feb 7, 2024
204b109
Also process the win-arm64 android cross packs (#98061)
lewing Feb 7, 2024
bdd5d32
Use NetTool* TFM properties for msbuild tasks (#98098)
ViktorHofer Feb 7, 2024
62d7c6a
Improve Math.Round, Math.ILogB, and do some minor cleanup of Half, Si…
tannergooding Feb 7, 2024
93cbd9f
Ensure that Vector512 uses the same patterns as Vector64/128/256 (#97…
tannergooding Feb 7, 2024
6a2a4ac
Use VM's copy of daccess.h (#97751)
MichalStrehovsky Feb 7, 2024
0fafa50
Disabling tests failing on Firefox. (#98103)
ilonatommy Feb 7, 2024
5501afd
Late cast expansion: remove the null check if possible (#97234)
EgorBo Feb 7, 2024
fdca8cb
Add internal nuget to package tasks, and targets for workload testing…
radical Feb 7, 2024
9655619
Disable vector ctors intrinsics on wasm (#98114)
jkurdek Feb 7, 2024
b449152
Add Sve.IsSupported support (#97814)
a74nh Feb 7, 2024
27d136d
Remove loop edge likelihood heuristics
amanasifkhalid Feb 7, 2024
36f0d8c
JIT: ARM64 SVE format encodings, `SVE_ID_2A` to `SVE_JH_2A` (#98015)
TIHan Feb 8, 2024
039cd77
Remove unused flag in Uri (#98076)
MihaZupan Feb 8, 2024
2b01564
Fix interpreter (#97935)
nikolahua Feb 8, 2024
607c1bf
[browser] remove memory snapshot feature (#98093)
pavelsavara Feb 8, 2024
95fc3d6
JIT: stopping preference for ML CSE heuristic (#98063)
AndyAyersMS Feb 8, 2024
e6b5da2
[mono] Don't pass c/c++ specific flags for .asm files on Windows (#98…
akoeplinger Feb 8, 2024
a78ddcc
JIT: Generalize jump threading very slightly (#98107)
jakobbotsch Feb 8, 2024
de1d1a0
Update Bionic docs (#98088)
MichalStrehovsky Feb 8, 2024
85fe8fe
Improve API documentation for Enumerable.Index (#98148)
eiriktsarpalis Feb 8, 2024
f64c078
Disable linker warning LNK4104 when building native AOT libraries (#9…
MichalStrehovsky Feb 8, 2024
5a9e1e7
Update TODOs for RiscV64 Machine and Architecture in Crossgen2 (#97021)
ashaurtaev Feb 8, 2024
9f3a439
Improved uninitialized object creation performance (#98016)
mikernet Feb 8, 2024
1c20e23
Move wasm threading library tests job from runtime-extra-platforms to…
akoeplinger Feb 8, 2024
b2bffbe
Ensure that the various `Max*Number` and `Min*Number` APIs optimize c…
tannergooding Feb 8, 2024
cd8057f
JIT: Use faster write barriers when we know the target address is on …
EgorBo Feb 8, 2024
e3165d6
Update TensorPrimitives to vectorize for size(T) is 1 or 2 (#97835)
stephentoub Feb 8, 2024
247f8cd
JIT ARM64-SVE: Add IF_SVE_GU_3*, IF_SVE_GX_3*, IF_SVE_FF_3*, IF_SVE_G…
amanasifkhalid Feb 8, 2024
f07b8f1
Merge branch 'profile-synthesis' of https://github.com/amanasifkhalid…
amanasifkhalid Feb 8, 2024
7bed0c2
Revert changes
amanasifkhalid Feb 8, 2024
81146c9
Set naive likelihoods when initializing preds
amanasifkhalid Feb 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<NetCoreAppMinimum>net8.0</NetCoreAppMinimum>
<NetCoreAppMinimum Condition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum>

<!-- when this is updated, make sure to keep $(_TargetFrameworkForNETCoreTasks)
<!-- when this is updated, make sure to keep $(_NetCoreAppToolCurrent)
in src/mono/wasm/build/WasmApp.LocalBuild.props
and in src/mono/msbuild/apple/build/AppleBuild.LocalBuild.props in sync -->
<NetCoreAppToolCurrentVersion>9.0</NetCoreAppToolCurrentVersion>
Expand All @@ -117,12 +117,6 @@
<!-- Important: Set this to the GA version (or a close approximation) during servicing and adjust the TFM property below. -->
<ApiCompatNetCoreAppBaselineVersion>8.0.0</ApiCompatNetCoreAppBaselineVersion>
<ApiCompatNetCoreAppBaselineTFM>net8.0</ApiCompatNetCoreAppBaselineTFM>

<TargetFrameworkForNETFrameworkTasks>$(NetFrameworkToolCurrent)</TargetFrameworkForNETFrameworkTasks>
<!-- Don't build for NETFramework during source-build. -->
<TargetFrameworkForNETFrameworkTasks Condition="'$(DotNetBuildFromSource)' == 'true'" />

<TargetFrameworkForNETCoreTasks>$(NetCoreAppToolCurrent)</TargetFrameworkForNETCoreTasks>
</PropertyGroup>

<PropertyGroup Label="CalculateConfiguration">
Expand Down
88 changes: 44 additions & 44 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@
<SourceBuild RepoName="emsdk" ManagedOnly="true" />
</Dependency>
<!-- Intermediate is necessary for source build. -->
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="9.0.0-alpha.1.24101.2">
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="9.0.0-alpha.1.24107.1">
<Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
<Sha>69b60d2af1775f374c91b3e52da02de6b7de1943</Sha>
<Sha>a739c05eb1a5200d7fa2f1e3977b4dc54fdec36a</Sha>
<SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
</Dependency>
<!-- Intermediate is necessary for source build. -->
Expand All @@ -124,87 +124,87 @@
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<!-- Intermediate is necessary for source build. -->
<Dependency Name="Microsoft.SourceBuild.Intermediate.arcade" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.SourceBuild.Intermediate.arcade" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
<SourceBuild RepoName="arcade" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.XliffTasks" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.GenAPI" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.GenAPI" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.GenFacades" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.GenFacades" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XUnitAssert" Version="2.6.7-beta.24081.4">
<Dependency Name="Microsoft.DotNet.XUnitAssert" Version="2.6.7-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XUnitExtensions" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.XUnitExtensions" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.XUnitConsoleRunner" Version="2.6.7-beta.24081.4">
<Dependency Name="Microsoft.DotNet.XUnitConsoleRunner" Version="2.6.7-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Archives" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Build.Tasks.Archives" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Packaging" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Build.Tasks.Packaging" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Installers" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Build.Tasks.Installers" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Templating" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Build.Tasks.Templating" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Workloads" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Build.Tasks.Workloads" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.CodeAnalysis" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.CodeAnalysis" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.TargetFramework" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Build.Tasks.TargetFramework" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.RemoteExecutor" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.RemoteExecutor" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Build.Tasks.Feed" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.Build.Tasks.Feed" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.VersionTools.Tasks" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.VersionTools.Tasks" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.SharedFramework.Sdk" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.SharedFramework.Sdk" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="System.ComponentModel.TypeConverter.TestData" Version="9.0.0-beta.24072.1">
<Uri>https://github.com/dotnet/runtime-assets</Uri>
Expand Down Expand Up @@ -360,9 +360,9 @@
<Uri>https://github.com/dotnet/xharness</Uri>
<Sha>f49b5c0db06528a9580686a5b63b0e5b4aba566b</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.PackageTesting" Version="9.0.0-beta.24081.4">
<Dependency Name="Microsoft.DotNet.PackageTesting" Version="9.0.0-beta.24106.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>438a8e2488313fb3aa1b24a741a85c2669ee7e0d</Sha>
<Sha>f7eb7794c703dc29a83b414b786e9a154f0ca042</Sha>
</Dependency>
<Dependency Name="optimization.windows_nt-x64.MIBC.Runtime" Version="1.0.0-prerelease.24071.2">
<Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-optimization</Uri>
Expand Down
32 changes: 16 additions & 16 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -83,22 +83,22 @@
<!-- SDK dependencies -->
<MicrosoftDotNetApiCompatTaskVersion>9.0.100-alpha.1.24072.3</MicrosoftDotNetApiCompatTaskVersion>
<!-- Arcade dependencies -->
<MicrosoftDotNetBuildTasksFeedVersion>9.0.0-beta.24081.4</MicrosoftDotNetBuildTasksFeedVersion>
<MicrosoftDotNetCodeAnalysisVersion>9.0.0-beta.24081.4</MicrosoftDotNetCodeAnalysisVersion>
<MicrosoftDotNetGenAPIVersion>9.0.0-beta.24081.4</MicrosoftDotNetGenAPIVersion>
<MicrosoftDotNetGenFacadesVersion>9.0.0-beta.24081.4</MicrosoftDotNetGenFacadesVersion>
<MicrosoftDotNetXUnitAssertVersion>2.6.7-beta.24081.4</MicrosoftDotNetXUnitAssertVersion>
<MicrosoftDotNetXUnitExtensionsVersion>9.0.0-beta.24081.4</MicrosoftDotNetXUnitExtensionsVersion>
<MicrosoftDotNetXUnitConsoleRunnerVersion>2.6.7-beta.24081.4</MicrosoftDotNetXUnitConsoleRunnerVersion>
<MicrosoftDotNetBuildTasksArchivesVersion>9.0.0-beta.24081.4</MicrosoftDotNetBuildTasksArchivesVersion>
<MicrosoftDotNetBuildTasksInstallersVersion>9.0.0-beta.24081.4</MicrosoftDotNetBuildTasksInstallersVersion>
<MicrosoftDotNetBuildTasksPackagingVersion>9.0.0-beta.24081.4</MicrosoftDotNetBuildTasksPackagingVersion>
<MicrosoftDotNetBuildTasksTargetFrameworkVersion>9.0.0-beta.24081.4</MicrosoftDotNetBuildTasksTargetFrameworkVersion>
<MicrosoftDotNetBuildTasksTemplatingVersion>9.0.0-beta.24081.4</MicrosoftDotNetBuildTasksTemplatingVersion>
<MicrosoftDotNetBuildTasksWorkloadsPackageVersion>9.0.0-beta.24081.4</MicrosoftDotNetBuildTasksWorkloadsPackageVersion>
<MicrosoftDotNetRemoteExecutorVersion>9.0.0-beta.24081.4</MicrosoftDotNetRemoteExecutorVersion>
<MicrosoftDotNetVersionToolsTasksVersion>9.0.0-beta.24081.4</MicrosoftDotNetVersionToolsTasksVersion>
<MicrosoftDotNetPackageTestingVersion>9.0.0-beta.24081.4</MicrosoftDotNetPackageTestingVersion>
<MicrosoftDotNetBuildTasksFeedVersion>9.0.0-beta.24106.2</MicrosoftDotNetBuildTasksFeedVersion>
<MicrosoftDotNetCodeAnalysisVersion>9.0.0-beta.24106.2</MicrosoftDotNetCodeAnalysisVersion>
<MicrosoftDotNetGenAPIVersion>9.0.0-beta.24106.2</MicrosoftDotNetGenAPIVersion>
<MicrosoftDotNetGenFacadesVersion>9.0.0-beta.24106.2</MicrosoftDotNetGenFacadesVersion>
<MicrosoftDotNetXUnitAssertVersion>2.6.7-beta.24106.2</MicrosoftDotNetXUnitAssertVersion>
<MicrosoftDotNetXUnitExtensionsVersion>9.0.0-beta.24106.2</MicrosoftDotNetXUnitExtensionsVersion>
<MicrosoftDotNetXUnitConsoleRunnerVersion>2.6.7-beta.24106.2</MicrosoftDotNetXUnitConsoleRunnerVersion>
<MicrosoftDotNetBuildTasksArchivesVersion>9.0.0-beta.24106.2</MicrosoftDotNetBuildTasksArchivesVersion>
<MicrosoftDotNetBuildTasksInstallersVersion>9.0.0-beta.24106.2</MicrosoftDotNetBuildTasksInstallersVersion>
<MicrosoftDotNetBuildTasksPackagingVersion>9.0.0-beta.24106.2</MicrosoftDotNetBuildTasksPackagingVersion>
<MicrosoftDotNetBuildTasksTargetFrameworkVersion>9.0.0-beta.24106.2</MicrosoftDotNetBuildTasksTargetFrameworkVersion>
<MicrosoftDotNetBuildTasksTemplatingVersion>9.0.0-beta.24106.2</MicrosoftDotNetBuildTasksTemplatingVersion>
<MicrosoftDotNetBuildTasksWorkloadsPackageVersion>9.0.0-beta.24106.2</MicrosoftDotNetBuildTasksWorkloadsPackageVersion>
<MicrosoftDotNetRemoteExecutorVersion>9.0.0-beta.24106.2</MicrosoftDotNetRemoteExecutorVersion>
<MicrosoftDotNetVersionToolsTasksVersion>9.0.0-beta.24106.2</MicrosoftDotNetVersionToolsTasksVersion>
<MicrosoftDotNetPackageTestingVersion>9.0.0-beta.24106.2</MicrosoftDotNetPackageTestingVersion>
<!-- TODO: Remove pinned xunit.analyzers version: https://github.com/dotnet/runtime/issues/97088 -->
<XUnitAnalyzersVersion>1.4.0</XUnitAnalyzersVersion>
<!-- NuGet dependencies -->
Expand Down
6 changes: 3 additions & 3 deletions eng/common/tools.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ function InitializeVisualStudioMSBuild([bool]$install, [object]$vsRequirements =

# If the version of msbuild is going to be xcopied,
# use this version. Version matches a package here:
# https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-eng/NuGet/RoslynTools.MSBuild/versions/17.8.5
# https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-eng/NuGet/Microsoft.DotNet.Arcade.MSBuild.Xcopy/versions/17.8.5
$defaultXCopyMSBuildVersion = '17.8.5'

if (!$vsRequirements) {
Expand Down Expand Up @@ -445,7 +445,7 @@ function InitializeVisualStudioMSBuild([bool]$install, [object]$vsRequirements =
if ($xcopyMSBuildVersion.Trim() -ine "none") {
$vsInstallDir = InitializeXCopyMSBuild $xcopyMSBuildVersion $install
if ($vsInstallDir -eq $null) {
throw "Could not xcopy msbuild. Please check that package 'RoslynTools.MSBuild @ $xcopyMSBuildVersion' exists on feed 'dotnet-eng'."
throw "Could not xcopy msbuild. Please check that package 'Microsoft.DotNet.Arcade.MSBuild.Xcopy @ $xcopyMSBuildVersion' exists on feed 'dotnet-eng'."
}
}
if ($vsInstallDir -eq $null) {
Expand Down Expand Up @@ -482,7 +482,7 @@ function InstallXCopyMSBuild([string]$packageVersion) {
}

function InitializeXCopyMSBuild([string]$packageVersion, [bool]$install) {
$packageName = 'RoslynTools.MSBuild'
$packageName = 'Microsoft.DotNet.Arcade.MSBuild.Xcopy'
$packageDir = Join-Path $ToolsDir "msbuild\$packageVersion"
$packagePath = Join-Path $packageDir "$packageName.$packageVersion.nupkg"

Expand Down
12 changes: 12 additions & 0 deletions eng/pipelines/common/evaluate-default-paths.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ parameters:
eng/testing/tests.browser.targets
eng/testing/tests.was*.targets
eng/testing/was*provisioning.targets
eng/testing/workloads-browser.targets
eng/testing/workloads-testing.targets
eng/testing/workloads-wasi.targets
eng/testing/workloads-wasm.targets
src/libraries/sendtohelix-browser.targets
src/libraries/sendtohelix-wasi.targets
src/libraries/sendtohelix-wasm.targets
Expand All @@ -25,6 +28,7 @@ parameters:
src/mono/nuget/Microsoft.NET.Runtime.wasm.Sample.Mono/*
src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/*
src/mono/nuget/Microsoft.NETCore.BrowserDebugHost.Transport/*
src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/*
src/mono/nuget/Microsoft.NET.Workload*
src/mono/sample/wasm/*
src/mono/browser/*
Expand Down Expand Up @@ -209,7 +213,11 @@ jobs:
- eng/testing/scenarios/BuildWasmAppsJobsList.txt
- eng/testing/tests.browser.targets
- eng/testing/tests.was*.targets
- src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/WorkloadTesting.Core.targets
- eng/testing/workloads-browser.targets
- eng/testing/workloads-testing.targets
- eng/testing/workloads-wasi.targets
- eng/testing/workloads-wasm.targets
- src/installer/pkg/sfx/Microsoft.NETCore.App/*
- src/libraries/sendtohelix*
- src/libraries/System.Net.WebSockets.Client/*
Expand Down Expand Up @@ -295,7 +303,11 @@ jobs:
exclude:
- eng/testing/scenarios/BuildWasiAppsJobsList.txt
- eng/testing/scenarios/BuildWasmAppsJobsList.txt
src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/WorkloadTesting.Core.targets
- eng/testing/workloads-browser.targets
- eng/testing/workloads-testing.targets
- eng/testing/workloads-wasi.targets
- eng/testing/workloads-wasm.targets
- src/mono/mono/component/mini-wasm-debugger.c
- src/mono/browser/debugger/*
- src/mono/wasm/host/*
Expand Down
23 changes: 21 additions & 2 deletions eng/pipelines/common/templates/wasm-library-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ parameters:
platforms: []
scenarios: ['normal']
shouldContinueOnError: false
shouldRunSmokeOnly: false
shouldRunSmokeOnly: false

jobs:

Expand Down Expand Up @@ -39,8 +39,27 @@ jobs:
eq(dependencies.evaluate_paths.outputs['SetPathVars_wasm_chrome.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_wasm_specific_except_wbt_dbg.containsChange'], true))
]
# run smoke tests only if:
# - explicitly requested
# - libraries or illink changed and no wasm specific changes
- name: shouldRunSmokeOnlyVar
value: $[
or(
eq('${{ parameters.shouldRunSmokeOnly }}', 'true'),
and(
eq('${{ parameters.shouldRunSmokeOnly }}', 'onLibrariesAndIllinkChanges'),
ne(variables['wasmDarcDependenciesChanged'], true),
or(
eq(dependencies.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange'], true),
eq(dependencies.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true)
),
ne(dependencies.evaluate_paths.outputs['SetPathVars_wasm_chrome.containsChange'], true),
ne(dependencies.evaluate_paths.outputs['SetPathVars_wasm_specific_except_wbt_dbg.containsChange'], true)
)
)
]
- name: _wasmRunSmokeTestsOnlyArg
value: /p:RunSmokeTestsOnly=${{ eq(parameters.shouldRunSmokeOnly, true) }}
value: /p:RunSmokeTestsOnly=$(shouldRunSmokeOnlyVar)
- name: chromeInstallArg
${{ if containsValue(parameters.scenarios, 'wasmtestonbrowser') }}:
value: /p:InstallChromeForTests=true
Expand Down
18 changes: 0 additions & 18 deletions eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,24 +117,6 @@ jobs:
- WasmTestOnBrowser
- WasmTestOnNodeJS

# Library tests with full threading
- template: /eng/pipelines/common/templates/wasm-library-tests.yml
parameters:
platforms:
- browser_wasm
#- browser_wasm_win
nameSuffix: _Threading
extraBuildArgs: /p:WasmEnableThreads=true /p:AotHostArchitecture=x64 /p:AotHostOS=$(_hostedOS)
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
# Always run for runtime-wasm because tests are not run in runtime
alwaysRun: ${{ parameters.isWasmOnlyBuild }}

scenarios:
- WasmTestOnBrowser
#- WasmTestOnNodeJS - this is not supported yet, https://github.com/dotnet/runtime/issues/85592


# EAT Library tests - only run on linux
- template: /eng/pipelines/common/templates/wasm-library-aot-tests.yml
parameters:
Expand Down
Loading