Ensure that constant folding for SIMD shifts on xarch follow the correct behavior on overshift #98001
Conversation
…ect behavior on overshift
ghost
added
the
area-CodeGen-coreclr
|
CC. @EgorBo, could you give this a review since you've also looked at the user reported issue already. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis resolves #93698 by ensuring the correct behavior is followed. As per the comments in the code, the xplat paths already enforce masking of the constant to ensure that it is "in range" and so they can never hit the constant folding path with an overshift. Only direct user usage of
|
src/tests/JIT/Regression/JitBlue/Runtime_93698/Runtime_93698.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7805915319 |
|
@tannergooding backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Ensure that constant folding for SIMD shifts on xarch follow the correct behavior on overshift
Using index info to reconstruct a base tree...
M src/coreclr/jit/hwintrinsicxarch.cpp
M src/coreclr/jit/valuenum.cpp
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/jit/valuenum.cpp
CONFLICT (content): Merge conflict in src/coreclr/jit/valuenum.cpp
Auto-merging src/coreclr/jit/hwintrinsicxarch.cpp
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Ensure that constant folding for SIMD shifts on xarch follow the correct behavior on overshift
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@tannergooding an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
…ect behavior on overshift (dotnet#98001) * Ensure that constant folding for SIMD shifts on xarch follow the correct behavior on overshift * Ensure we test Sse2.IsSupported
This resolves #93698 by ensuring the correct behavior is followed. As per the comments in the code, the xplat paths already enforce masking of the constant to ensure that it is "in range" and so they can never hit the constant folding path with an overshift. Only direct user usage of
Sse2.ShiftLeftLogical(or similar) can hit this path.