Skip to content

[release/8.0-staging] Stop trying to format HOST_RUNTIME_CONTRACT property with locale settings #97891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Feb 2, 2024

Partial backport of #95801 to release/8.0-staging - skips the changes to utils for ends_with / starts_with.

Customer Impact

  • Customer reported
  • Found internally

Reported in:

In environments with certain locale settings, the runtime fails to initialize due to an incorrect runtime property. The host passes a runtime contract pointer as a property to the runtime, but it is incorrectly formatting it based on locale settings. The fix switches the computation of the property to use a function that is non-locale-dependent (stops using stringstream in favour of printf).

Regression

  • Yes
  • No

This is a new property in 8.0. It used the same mechanism that was used a different property in past releases (which would have the same issue), but that was only for single-file. In this case, it is for general initialization.

Testing

Manual

Risk

Low

@elinor-fung elinor-fung added Servicing-consider Issue for next servicing release review area-Host labels Feb 2, 2024
@elinor-fung elinor-fung added this to the 8.0.x milestone Feb 2, 2024
@ghost
Copy link

ghost commented Feb 2, 2024

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Partial backport of #95801 to release/8.0-staging - skips the changes to utils for ends_with / starts_with.

Customer Impact

  • Customer reported
  • Found internally

Reported in:

In environments with certain locale settings, the runtime fails to initialize due to an incorrect runtime property. The host passes a runtime contract pointer as a property to the runtime, but it is incorrectly formatting it based on locale settings.

Regression

  • Yes
  • No

This is a new property in 8.0. It used the same mechanism that was used a different property in past releases (which would have the same issue), but that was only for single-file. In this case, it is for general initialization.

Testing

Manual

Risk

Low

Author: elinor-fung
Assignees: -
Labels:

Servicing-consider, area-Host

Milestone: 8.0.x

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@rbhanda rbhanda modified the milestones: 8.0.x, 8.0.3 Feb 6, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 6, 2024
@jeffschwMSFT jeffschwMSFT merged commit 4b040aa into dotnet:release/8.0-staging Feb 9, 2024
@elinor-fung elinor-fung deleted the fix97086 branch February 9, 2024 23:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HOST_RUNTIME_CONTRACT has invalid value on custom .NET runtime host on Linux
3 participants