Remove HELPER_METHOD_FRAMEs from built-in marshalers #97432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n managed code instead of FCALLs
ghost
assigned
jkoritzinsky
force-pushed
the
helper-method-frame-removal
branch
from
17b9d4f to
2fab541
Compare
jkoritzinsky
force-pushed
the
helper-method-frame-removal
branch
from
2fab541 to
5e59fc9
Compare
jkotas
reviewed
Jan 24, 2024
huoyaoyuan
reviewed
Jan 24, 2024
This was referenced Jan 24, 2024
…or marshalers that already have the state type defined in managed code.
…le, fix test failures.
This was referenced Feb 2, 2024
…he custom marshaler object itself.
This was referenced Feb 3, 2024
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
jkotas
reviewed
Feb 8, 2024
src/coreclr/vm/ilmarshalers.cpp
Outdated
|
|
||
| BASEARRAYREF arrayRef = (BASEARRAYREF) *pManagedHome; | ||
| BASEARRAYREF arrayRef = NULL; | ||
| GCPROTECT_BEGIN(arrayRef); |
There was a problem hiding this comment.
Nit: You do not need to GCPROTECT the copy of arg in situations like this. It is cheaper to do pManagedHome.Get multiple times instead.
jkotas
reviewed
Feb 8, 2024
jkotas
reviewed
Feb 8, 2024
jkotas
reviewed
Feb 8, 2024
This was referenced Feb 8, 2024
…/runtime into helper-method-frame-removal
jkotas
reviewed
Feb 8, 2024
jkotas
reviewed
Feb 8, 2024
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
Failures are known. Merging this in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in marshalers that were implemented in native code used FCalls. Change them to use QCalls or (in the case of some simple methods that don't marshal and the
ICustomMarshalermarshaler), move the implementation to managed code.