Skip to content

[release/8.0-staging] [browser] Use whole assembly name when looking for already loaded assemblies #97144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maraf
Copy link
Member

@maraf maraf commented Jan 18, 2024

Backport of #96951 to release/8.0-staging

Customer Impact

Fixes customer reported issue caused in 8.0 when migrating features from Blazor for runtime. The lazy loading failed when user was lazy loading an assembly with name that matches part of some of the runtime assemblies name.

Testing

Automated test.

Risk

Low. Effects only Blazor users using lazy loading feature.

@maraf maraf added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jan 18, 2024
@maraf maraf added this to the 8.0.x milestone Jan 18, 2024
@maraf maraf self-assigned this Jan 18, 2024
@ghost
Copy link

ghost commented Jan 18, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #96951 to release/8.0-staging

Customer Impact

Testing

Risk

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: 8.0.x

@maraf maraf added the Servicing-consider Issue for next servicing release review label Jan 18, 2024
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 18, 2024
@rbhanda rbhanda modified the milestones: 8.0.x, 8.0.3 Jan 18, 2024
@maraf maraf merged commit e24179e into dotnet:release/8.0-staging Jan 19, 2024
@maraf maraf deleted the BrowserFixLazyAssemblyLoadedCheck80 branch January 19, 2024 08:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants