Make multiple calls to FinalRelease safe #97059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #96901
|
...s/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Jan 17, 2024
...s/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs
Outdated
Show resolved
Hide resolved
...s/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs
Outdated
Show resolved
Hide resolved
…e/InteropServices/Marshalling/ComObject.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com>
…e/InteropServices/Marshalling/ComObject.cs
jkoritzinsky
commented
Jan 17, 2024
...s/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs
Outdated
Show resolved
Hide resolved
…e/InteropServices/Marshalling/ComObject.cs
2 tasks
stephentoub
reviewed
Jan 18, 2024
...s/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 18, 2024
...s/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jan 18, 2024
...s/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs
Show resolved
Hide resolved
tmds
pushed a commit
to tmds/runtime
that referenced
this pull request
Jan 23, 2024
* Don't double-release a COM object * Add a test * Make the release thread-safe * Add using * Update src/libraries/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs Co-authored-by: Aaron Robinson <arobins@microsoft.com> * Update src/libraries/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs * Update src/libraries/System.Runtime.InteropServices/src/System/Runtime/InteropServices/Marshalling/ComObject.cs * Add name parameter * Fix analyzer error * SuppressFinalize earlier * Add tests for the exceptional scenarios --------- Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96901