Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collection expressions for UnmanagedCallConv.CallConvs #97017

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jan 16, 2024

More succint syntax. Related to #96964

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 16, 2024
@ghost ghost assigned jkotas Jan 16, 2024
@jkotas jkotas added area-System.Runtime.InteropServices and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 16, 2024
@ghost
Copy link

ghost commented Jan 16, 2024

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

More succint syntax. Related to #96964

Author: jkotas
Assignees: jkotas
Labels:

area-System.Runtime.InteropServices

Milestone: -

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! Also gets the syntax a little closer to the function pointer syntax for the calling conventions, which is nice too.

@jkotas
Copy link
Member Author

jkotas commented Jan 16, 2024

I love it! Also gets the syntax a little closer to the function pointer syntax for the calling conventions, which is nice too.

+1

We can start using it in source generators and samples over time.

@jkotas jkotas merged commit 1c860e2 into dotnet:main Jan 16, 2024
173 of 179 checks passed
@jkotas jkotas deleted the collection-expr branch January 16, 2024 13:46
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants