Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify RuntimeType.SplitName #96991

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Simplify RuntimeType.SplitName #96991

merged 2 commits into from
Jan 15, 2024

Conversation

lilinus
Copy link
Contributor

@lilinus lilinus commented Jan 15, 2024

String.Substring already has logic to return String.Empty if result length is zero

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jan 15, 2024
@ghost
Copy link

ghost commented Jan 15, 2024

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

String.Substring already has logic to return String.Empty if result length is zero

Author: lilinus
Assignees: -
Labels:

area-System.Reflection
Milestone: -

This was referenced Jan 15, 2024
Closed
Closed
Closed
jkotas
jkotas approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit a77c0b4 into dotnet:main Jan 15, 2024
110 checks passed
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
@lilinus @tmds
Simplify RuntimeType.SplitName (dotnet#96991)
a63903b
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@lilinus lilinus deleted the simplify-runtimetype.splitname branch April 11, 2024 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
area-System.Reflection community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilinus @jkotas