EventPipe: Don't clean up thread list on shutdown #96936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lateralusX
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
I think we should revisit the shutdown/uninitialize approach of EventPipe at some time, so we can split what's being called at shutdown vs potential unloading of the library in embedding scenarios in cases where the process continue to execute after the runtime has been unloaded and potentially reloaded.
|
Build analysis says all failures are known, merging. |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7577481505 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a report of a crash in EventPipe where the app was shutting down, and after
_ep_threads_lockwas freed a new thread was trying to fire an event and ran in to an AV trying to lock_ep_threads_lockto check if the thread was known.This PR cleans up some dead code and makes
_ep_threads_lockfollow the approach we've been taking for some time now, to not clean up and let the OS deal with it after process exit.